Speed up common ObjectProtoToString cases

Speed up common ObjectProtoToString cases

1) avoid the builder
2) by precomputing the result we're guaranteed to have a flat string
avoiding extra cost later of using the string

BUG=

Committed: https://crrev.com/155a392be1931046222113ff8037186788ba9f4b
Cr-Commit-Position: refs/heads/master@{#36352}

[Toon Verwaest, 2016-05-18 14:23:24]

verwaest@chromium.org changed reviewers:
+ adamk@chromium.org

[Toon Verwaest, 2016-05-18 14:23:25]

ptal. this speeds up speedometer-angular from ~680 to ~630

[Toon Verwaest, 2016-05-18 14:23:38]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-18 14:23:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988023004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988023004/1

[commit-bot: I haz the power, 2016-05-18 14:56:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 14:56:20]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-05-18 16:07:58]

lgtm (I have a vague memory of doing this same thing myself once), might want to
mention the bootstrapper cleanup in the CL description if my inference is
correct.

Also (only tangentially related to this patch) should we be sweeping the
codebase looking for callers of IsUndefined and IsNull and looking to replace
them with these direct comparisons instead? Maybe provide free functions
somewhere that take an Isolate?

https://codereview.chromium.org/1988023004/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (left):

https://codereview.chromium.org/1988023004/diff/1/src/bootstrapper.cc#oldcode...
src/bootstrapper.cc:1590: cons->shared()->set_instance_class_name(*name);
This in the below are just cleanup because JSON and Math aren't constructible,
correct?

[Toon Verwaest, 2016-05-18 17:17:20]

Yeah probably we should have IsNull(Isolate*)...

https://codereview.chromium.org/1988023004/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (left):

https://codereview.chromium.org/1988023004/diff/1/src/bootstrapper.cc#oldcode...
src/bootstrapper.cc:1590: cons->shared()->set_instance_class_name(*name);
On 2016/05/18 16:07:58, adamk wrote:
> This in the below are just cleanup because JSON and Math aren't constructible,
> correct?

It actually affects Object.prototype.toString.call(JSON) after deleting
toStringTag. I can either add a test and update the description, or move it out
of the CL...

[adamk, 2016-05-18 17:46:05]

https://codereview.chromium.org/1988023004/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (left):

https://codereview.chromium.org/1988023004/diff/1/src/bootstrapper.cc#oldcode...
src/bootstrapper.cc:1590: cons->shared()->set_instance_class_name(*name);
On 2016/05/18 17:17:20, Toon Verwaest wrote:
> On 2016/05/18 16:07:58, adamk wrote:
> > This in the below are just cleanup because JSON and Math aren't
constructible,
> > correct?
> 
> It actually affects Object.prototype.toString.call(JSON) after deleting
> toStringTag. I can either add a test and update the description, or move it
out
> of the CL...

Let's move it out of this CL, leaving it as a pure perf win, and do it in a
followup along with a test case.

[Toon Verwaest, 2016-05-19 08:08:35]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-05-19 08:08:36]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1988023004/#ps20001
(title: "restore bootstrapper")

[commit-bot: I haz the power, 2016-05-19 08:08:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988023004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988023004/20001

[commit-bot: I haz the power, 2016-05-19 08:51:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-19 08:53:19]

Description was changed from

==========
Speed up common ObjectProtoToString cases

1) avoid the builder
2) by precomputing the result we're guaranteed to have a flat string
avoiding extra cost later of using the string

BUG=
==========

to

==========
Speed up common ObjectProtoToString cases

1) avoid the builder
2) by precomputing the result we're guaranteed to have a flat string
avoiding extra cost later of using the string

BUG=

Committed: https://crrev.com/155a392be1931046222113ff8037186788ba9f4b
Cr-Commit-Position: refs/heads/master@{#36352}
==========

[commit-bot: I haz the power, 2016-05-19 08:53:20]

Patchset 2 (id:??) landed as
https://crrev.com/155a392be1931046222113ff8037186788ba9f4b
Cr-Commit-Position: refs/heads/master@{#36352}