Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: BUILD.gn

Issue 1988023003: [gn] Port icu_use_data_file_flag in gn (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build_overrides/v8.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index aee9fe4ad1a551c87a4906ab740937f9a3347f9f..d9453c1649d4e2a934cb95e5fd102e43bc5049f1 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -18,6 +18,10 @@ import("//build_overrides/v8.gni")
import("snapshot_toolchain.gni")
declare_args() {
+ # Use ICU data file (icudtl.dat) if true or library (shared on windows,
+ # static otherwise).
+ icu_use_data_file_flag = true
+
# Enable the snapshot feature, for fast context creation.
# http://v8project.blogspot.com/2015/09/custom-startup-snapshots.html
v8_use_snapshot = true
@@ -1836,8 +1840,13 @@ v8_source_set("v8_base") {
deps += [ "//third_party/icu:icudata" ]
}
- # TODO(jochen): Add support for icu_use_data_file_flag
- defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE" ]
+ if (icu_use_data_file_flag) {
+ defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE" ]
+ } else if (is_win) {
+ defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_SHARED" ]
+ } else {
+ defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC" ]
+ }
} else {
sources -= [
"src/i18n.cc",
« no previous file with comments | « no previous file | build_overrides/v8.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698