Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: BUILD.gn

Issue 1988023003: [gn] Port icu_use_data_file_flag in gn (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build_overrides/v8.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/arm.gni") 6 import("//build/config/arm.gni")
7 import("//build/config/mips.gni") 7 import("//build/config/mips.gni")
8 import("//build/config/sanitizers/sanitizers.gni") 8 import("//build/config/sanitizers/sanitizers.gni")
9 9
10 if (is_android) { 10 if (is_android) {
11 import("//build/config/android/rules.gni") 11 import("//build/config/android/rules.gni")
12 } 12 }
13 13
14 # Because standalone V8 builds are not supported, assume this is part of a 14 # Because standalone V8 builds are not supported, assume this is part of a
15 # Chromium build. 15 # Chromium build.
16 import("//build_overrides/v8.gni") 16 import("//build_overrides/v8.gni")
17 17
18 import("snapshot_toolchain.gni") 18 import("snapshot_toolchain.gni")
19 19
20 declare_args() { 20 declare_args() {
21 # Use ICU data file (icudtl.dat) if true or library (shared on windows,
22 # static otherwise).
23 icu_use_data_file_flag = true
24
21 # Enable the snapshot feature, for fast context creation. 25 # Enable the snapshot feature, for fast context creation.
22 # http://v8project.blogspot.com/2015/09/custom-startup-snapshots.html 26 # http://v8project.blogspot.com/2015/09/custom-startup-snapshots.html
23 v8_use_snapshot = true 27 v8_use_snapshot = true
24 28
25 # Use external files for startup data blobs: 29 # Use external files for startup data blobs:
26 # the JS builtins sources and the start snapshot. 30 # the JS builtins sources and the start snapshot.
27 v8_use_external_startup_data = true 31 v8_use_external_startup_data = true
28 32
29 # Sets -DVERIFY_HEAP. 33 # Sets -DVERIFY_HEAP.
30 v8_enable_verify_heap = false 34 v8_enable_verify_heap = false
(...skipping 1798 matching lines...) Expand 10 before | Expand all | Expand 10 after
1829 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 1833 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
1830 cflags = [ "/wd4267" ] 1834 cflags = [ "/wd4267" ]
1831 } 1835 }
1832 1836
1833 if (v8_enable_i18n_support) { 1837 if (v8_enable_i18n_support) {
1834 deps += [ "//third_party/icu" ] 1838 deps += [ "//third_party/icu" ]
1835 if (is_win) { 1839 if (is_win) {
1836 deps += [ "//third_party/icu:icudata" ] 1840 deps += [ "//third_party/icu:icudata" ]
1837 } 1841 }
1838 1842
1839 # TODO(jochen): Add support for icu_use_data_file_flag 1843 if (icu_use_data_file_flag) {
1840 defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE" ] 1844 defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE" ]
1845 } else if (is_win) {
1846 defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_SHARED" ]
1847 } else {
1848 defines += [ "ICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC" ]
1849 }
1841 } else { 1850 } else {
1842 sources -= [ 1851 sources -= [
1843 "src/i18n.cc", 1852 "src/i18n.cc",
1844 "src/i18n.h", 1853 "src/i18n.h",
1845 ] 1854 ]
1846 } 1855 }
1847 1856
1848 if (v8_postmortem_support) { 1857 if (v8_postmortem_support) {
1849 sources += [ "$target_gen_dir/debug-support.cc" ] 1858 sources += [ "$target_gen_dir/debug-support.cc" ]
1850 deps += [ ":postmortem-metadata" ] 1859 deps += [ ":postmortem-metadata" ]
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
2187 sources = [ 2196 sources = [
2188 "test/fuzzer/wasm-asmjs.cc", 2197 "test/fuzzer/wasm-asmjs.cc",
2189 ] 2198 ]
2190 2199
2191 deps = [ 2200 deps = [
2192 ":fuzzer_support", 2201 ":fuzzer_support",
2193 ] 2202 ]
2194 2203
2195 configs = [ ":internal_config" ] 2204 configs = [ ":internal_config" ]
2196 } 2205 }
OLDNEW
« no previous file with comments | « no previous file | build_overrides/v8.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698