Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1987993002: Only mention the App Launcher on ChromeOS for the "Use a prediction service.." setting (Closed)

Created:
4 years, 7 months ago by tapted
Modified:
4 years, 7 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only mention the App Launcher on ChromeOS for the "Use a prediction service.." setting It currently says, "Use a prediction service to help complete searches and URLs typed in the address bar or the app launcher search box" App Launcher only exists on ChromeOS now, so drop the "or the app launcher.." bit on other platforms. BUG=612651 Committed: https://crrev.com/b02dc0c635b2d936f56cdeb90efce61f0aef35e6 Cr-Commit-Position: refs/heads/master@{#394368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tapted
Hi matt, please take a look
4 years, 7 months ago (2016-05-18 07:11:48 UTC) #2
Matt Giuca
lgtm
4 years, 7 months ago (2016-05-18 07:16:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987993002/1
4 years, 7 months ago (2016-05-18 08:45:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 09:13:43 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 09:15:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b02dc0c635b2d936f56cdeb90efce61f0aef35e6
Cr-Commit-Position: refs/heads/master@{#394368}

Powered by Google App Engine
This is Rietveld 408576698