third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation.html - Issue 1987983002: Remove Range.expand() method

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation.html

Issue 1987983002: Remove Range.expand() method Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/multicol/float-truncation-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/multicol/vertical-lr/float-truncation-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/text/international/cjk-segmentation.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html style="-webkit-writing-mode:vertical-lr">	1 <html style="-webkit-writing-mode:vertical-lr">

2 <style>	2 <style>

3 div.columns {	3 div.columns {

4 -webkit-columns: 2;	4 -webkit-columns: 2;

5 -webkit-column-gap: 0;	5 -webkit-column-gap: 0;

6 columns: 2;	6 columns: 2;

7 column-gap: 0;	7 column-gap: 0;

8 column-fill: auto;	8 column-fill: auto;

9 height: 200px;	9 height: 200px;

10 outline: 1px solid blue;	10 outline: 1px solid blue;

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 <div class="float" id="f5">	62 <div class="float" id="f5">

63 and one five line float	63 and one five line float

64 </div>	64 </div>

65 text runs here next to the float	65 text runs here next to the float

66 </div>	66 </div>

67 </div>	67 </div>

68 <pre id="result"></pre>	68 <pre id="result"></pre>

69 <script>	69 <script>

70 function floatOffset(float)	70 function floatOffset(float)

71 {	71 {

72 var range = document.createRange();	72 var selection = getSelection();

73 range.setStart(float, 0);	73 selection.collapse(float, 0);

74 range.setEnd(float, 0);	74 selection.modify("extend", "forward", "word");

75 range.expand("word");	75 var rect = selection.getRangeAt(0).getBoundingClientRect();

76 var rect = range.getBoundingClientRect();

77 var parentRect = float.parentNode.getBoundingClientRect();	76 var parentRect = float.parentNode.getBoundingClientRect();

78 return { width: rect.left - parentRect.left, height: rect.top - parentRe ct.top };	77 return { width: rect.left - parentRect.left, height: rect.top - parentRe ct.top };

79 }	78 }

80	79

81 var tests = [	80 var tests = [

82 ["f1", 45, 0],	81 ["f1", 45, 0],

83 ["f2", 45, 0],	82 ["f2", 45, 0],

84 ["f3", 45, 0],	83 ["f3", 45, 0],

85 ["f4", 55, 0],	84 ["f4", 55, 0],

86 ["f5", 15, 0]	85 ["f5", 15, 0]

(...skipping 12 matching lines...) Expand all Loading...
99 }	98 }

100 }	99 }

101	100

102 if (window.testRunner) {	101 if (window.testRunner) {

103 testRunner.dumpAsText();	102 testRunner.dumpAsText();

104 document.getElementById("tests").style.display = "none";	103 document.getElementById("tests").style.display = "none";

105 }	104 }

106	105

107 document.getElementById("result").innerText = failures ? "FAIL: " + failures + " cases failed" : "PASS";	106 document.getElementById("result").innerText = failures ? "FAIL: " + failures + " cases failed" : "PASS";

108 </script>	107 </script>

OLD	NEW