Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 1987963004: Estimate the required MediaCodec decoder max input buffer size (Closed)

Created:
4 years, 7 months ago by watk
Modified:
4 years, 7 months ago
Reviewers:
DaleCurtis
CC:
avayvod+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Estimate the required MediaCodec decoder max input buffer size In some cases MediaCodec doesn't give us input buffers that are big enough to contain the encoded data. Now we guess at the required size and set the KEY_MAX_INPUT_SIZE property. The heuristics come from exoplayer. BUG=596211 Committed: https://crrev.com/264d294d945e1beaaf4734a3824addae7d5c2dda Cr-Commit-Position: refs/heads/master@{#394894}

Patch Set 1 : #

Patch Set 2 : Link to exoplayer source #

Patch Set 3 : Make MimeTypes static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -0 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 1 3 chunks +50 lines, -0 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaCodecUtil.java View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
watk
4 years, 7 months ago (2016-05-18 22:34:46 UTC) #3
DaleCurtis
lgtm, want to add a link / comment saying this was pulled from ExoPlayer?
4 years, 7 months ago (2016-05-18 22:53:26 UTC) #4
DaleCurtis
We should also switch to using that mime type map in more places.
4 years, 7 months ago (2016-05-18 22:54:00 UTC) #5
watk
On 2016/05/18 22:53:26, DaleCurtis wrote: > lgtm, want to add a link / comment saying ...
4 years, 7 months ago (2016-05-18 23:03:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987963004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987963004/40001
4 years, 7 months ago (2016-05-18 23:04:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/68670)
4 years, 7 months ago (2016-05-18 23:56:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987963004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987963004/60001
4 years, 7 months ago (2016-05-19 19:00:36 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/232235)
4 years, 7 months ago (2016-05-19 21:40:12 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987963004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987963004/60001
4 years, 7 months ago (2016-05-19 21:43:45 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-05-19 23:05:06 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 23:06:10 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/264d294d945e1beaaf4734a3824addae7d5c2dda
Cr-Commit-Position: refs/heads/master@{#394894}

Powered by Google App Engine
This is Rietveld 408576698