Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issue 1987963002: remove animator from SampleApp (Closed)

Created:
4 years, 7 months ago by reed1
Modified:
4 years, 7 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove animator from SampleApp There is no xml parser hooked up, so the animator test file (already behind #if 0) is not testable. Removing the files to speedup building SampleApp. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1987963002 Committed: https://skia.googlesource.com/skia/+/d46e5859863c7401ceb90f1a62086865be957443

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M gyp/SampleApp.gyp View 4 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987963002/20001
4 years, 7 months ago (2016-05-18 02:14:05 UTC) #5
reed1
4 years, 7 months ago (2016-05-18 02:14:11 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 02:33:53 UTC) #9
caryclark
lgtm
4 years, 7 months ago (2016-05-18 11:33:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987963002/20001
4 years, 7 months ago (2016-05-18 13:54:22 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 13:55:20 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d46e5859863c7401ceb90f1a62086865be957443

Powered by Google App Engine
This is Rietveld 408576698