[wip] unprefix filter

third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp

 /*
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 233 matching lines @@
 
         // If the client has a layer (is a non-SVGElement) we need to signal
         // invalidation in the same way as is done in markAllResourceClientsForInvalidation above.
         if (layoutObject->hasLayer() && resourceType() == FilterResourceType) {
             if (style.hasFilter())
                 toLayoutBoxModelObject(layoutObject)->layer()->filterNeedsPaintInvalidation();
             // If this is the SVG root, we could have both 'filter' and
             // '-webkit-filter' applied, so we need to do the invalidation
             // below as well, unless we can optimistically determine that
             // 'filter' does not apply to the element in question.
-            if (!layoutObject->isSVGRoot() || !style.svgStyle().hasFilter())
+            // FIXME: resolve what TODO about the above comment, investigate
+            // who added it and why.

[Noel Gordon, 2016/05/23 03:28:24]

Deal with this FIXME.  Two layout tests fail if I just restore the old code:

  svg/filters/filter-on-svg-root-w-layer.html
  svg/custom/cross-referenced-resources.html

A full invalidation is still needed on the SVG root element if it has a filter. 
Adjust the code comment, and use the new code.  With that, the indicated layout
tests pass.

New patch uploaded: patch set #7.

+            if (!layoutObject->isSVGRoot() || !style.hasFilter())
                 continue;
         }
 
         StyleDifference diff;
         diff.setNeedsFullLayout();
         SVGResourcesCache::clientStyleChanged(layoutObject, diff, style);
         layoutObject->setNeedsLayoutAndFullPaintInvalidation(LayoutInvalidationReason::SvgResourceInvalidated);
     }
 }
 
@@ skipping 56 matching lines @@
             // This will process the rest of the ancestors.
             toLayoutSVGResourceContainer(current)->removeAllClientsFromCache();
             break;
         }
 
         current = current->parent();
     }
 }
 
 } // namespace blink