Chromium Code Reviews| Index: Source/modules/webdatabase/SQLTransactionBackendSync.h |
| diff --git a/Source/modules/webdatabase/SQLTransactionBackendSync.h b/Source/modules/webdatabase/SQLTransactionBackendSync.h |
| index cb0908e75a0d6e1786022a03dd00bec2ebfef009..3c2542c001c50a43bbfa61a331135fa394522623 100644 |
| --- a/Source/modules/webdatabase/SQLTransactionBackendSync.h |
| +++ b/Source/modules/webdatabase/SQLTransactionBackendSync.h |
| @@ -50,9 +50,10 @@ class SQLiteTransaction; |
| class ExceptionState; |
| // Instances of this class should be created and used only on the worker's context thread. |
| -class SQLTransactionBackendSync : public RefCounted<SQLTransactionBackendSync> { |
| +class SQLTransactionBackendSync : public RefCountedWillBeGarbageCollectedFinalized<SQLTransactionBackendSync> { |
| public: |
| ~SQLTransactionBackendSync(); |
|
haraken
2014/03/18 09:59:09
This could be a virtual destructor (although not b
|
| + void trace(Visitor*); |
|
haraken
2014/03/18 09:59:09
Shall we make this virtual and override it in SQLT
tkent
2014/03/19 04:58:39
I object to add such override. It would look very
|
| PassRefPtr<SQLResultSet> executeSQL(const String& sqlStatement, const Vector<SQLValue>& arguments, ExceptionState&); |
| @@ -62,11 +63,12 @@ public: |
| void execute(ExceptionState&); |
| void commit(ExceptionState&); |
| void rollback(); |
| + void rollbackIfInProgress(); |
| private: |
| SQLTransactionBackendSync(DatabaseSync*, PassOwnPtr<SQLTransactionSyncCallback>, bool readOnly); |
| - RefPtrWillBePersistent<DatabaseSync> m_database; |
| + RefPtrWillBeMember<DatabaseSync> m_database; |
| OwnPtr<SQLTransactionSyncCallback> m_callback; |
| bool m_readOnly; |
| bool m_hasVersionMismatch; |