Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 198793002: Perf regression: changes in KeyedStoreIC introduced polymorphism. (Closed)

Created:
6 years, 9 months ago by mvstanton
Modified:
6 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Perf regression: changes in KeyedStoreIC introduced polymorphism. When fixing bug 350884, I introduced an error that meant we went polymorphic in KeyedStoreIC where we stayed monomorphic before. This CL addresses the error, while preserving the bug fix for 350884. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M src/ic.cc View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Toon, There was an error in my KeyedStoreIC fix yesterday, happily found by Golem. ...
6 years, 9 months ago (2014-03-13 08:48:20 UTC) #1
Toon Verwaest
lgtm
6 years, 9 months ago (2014-03-13 10:47:00 UTC) #2
mvstanton
6 years, 9 months ago (2014-03-13 12:17:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19893 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698