Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1987903002: Create only a single LegacyRenderWidgetHostHWND per WebContentsViewAura. (Closed)

Created:
4 years, 7 months ago by dmazzoni
Modified:
4 years, 6 months ago
Reviewers:
ananta
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create only a single LegacyRenderWidgetHostHWND per WebContentsViewAura. This simplifies the LegacyRenderWidgetHostHWND lifecycle and helps with some accessibility and mouse wheel bugs. Originally landed as r301810 (http://crrev.com/387353004), rolled back because it broke NPAPI plug-ins. Re-landing now that NPAPI is dead. BUG=393665, 416316

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Revert unrelated changes #

Patch Set 4 : Revert unrelated changes #

Patch Set 5 : Fix renamed include #

Patch Set 6 : Get rid of win-only include #

Patch Set 7 : Get rid of duplicate AddObserver #

Patch Set 8 : Get rid of redundant 'virtual' #

Patch Set 9 : Get rid of code incorrectly merged into WCVA #

Patch Set 10 : Fix last merge issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -175 lines) Patch
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.h View 8 chunks +16 lines, -25 lines 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.cc View 6 chunks +43 lines, -45 lines 0 comments Download
A content/browser/renderer_host/legacy_render_widget_host_win_delegate.h View 1 chunk +26 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 4 5 3 chunks +4 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 11 chunks +22 lines, -87 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 2 3 4 5 6 7 4 chunks +29 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 3 4 5 6 7 8 9 6 chunks +75 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dmazzoni
Thanks for taking a fresh look at this change.
4 years, 7 months ago (2016-05-18 00:21:40 UTC) #3
dmazzoni
Want to consider this change?
4 years, 6 months ago (2016-05-31 18:09:19 UTC) #4
sky
4 years, 6 months ago (2016-05-31 20:51:41 UTC) #5 
This is all Ananta. I'm not an owner of any of these files.

Powered by Google App Engine
This is Rietveld 408576698