Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1987893002: Reland of [Mac][Material Design] Update bookmarks bar to Material Design. (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [Mac][Material Design] Update bookmarks bar to Material Design. (patchset #1 id:1 of https://codereview.chromium.org/1986963004/ ) Reason for revert: Broke the build (e.g. http://build.chromium.org/p/chromium.gpu/builders/GPU%20Mac%20Builder/builds/59678) Original issue's description: > Revert of [Mac][Material Design] Update bookmarks bar to Material Design. (patchset #17 id:320001 of https://codereview.chromium.org/1941583002/ ) > > Reason for revert: > Appears to have caused failure in unit test BookmarkBarControllerTest.LastBookmarkResizeBehavior on Mac 10.11 > > Logs: https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/1621/steps/unit_tests/logs/stdio > > Build: > https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/1621 > > Original issue's description: > > [Mac][Material Design] Update bookmarks bar to Material Design. > > > > This cl changes the bookmarks bar folder icons, button sizes, and hover > > state to match the Material Design spec. > > > > R=avi@chromium.org,cpu@chromium.org > > BUG=589941 > > > > Committed: https://crrev.com/e757665e44c261568486d052ecf38d79256a522d > > Cr-Commit-Position: refs/heads/master@{#394165} > > TBR=avi@chromium.org,cpu@chromium.org,ugurcan.polat12@gmail.com,shrike@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=589941 > > Committed: https://crrev.com/66fad9d351195d23d3bdafebd64b61c5a94bf789 > Cr-Commit-Position: refs/heads/master@{#394263} TBR=avi@chromium.org,cpu@chromium.org,ugurcan.polat12@gmail.com,shrike@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=589941 Committed: https://crrev.com/e83b1122b753bc3069bf1f59610d09970f9051e3 Cr-Commit-Position: refs/heads/master@{#394270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+576 lines, -155 lines) Patch
A chrome/app/theme/default_100_percent/mac/bookmark_bar_folder_managed_white.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/mac/bookmark_bar_folder_supervised_white.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/mac/bookmark_bar_folder_white.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/mac/bookmark_bar_folder_managed_white.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/mac/bookmark_bar_folder_supervised_white.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/mac/bookmark_bar_folder_white.png View Binary file 0 comments Download
A chrome/app/theme/material_100_percent/mac/bookmark_bar_folder.png View Binary file 0 comments Download
A chrome/app/theme/material_100_percent/mac/bookmark_bar_folder_managed.png View Binary file 0 comments Download
A chrome/app/theme/material_100_percent/mac/bookmark_bar_folder_supervised.png View Binary file 0 comments Download
A chrome/app/theme/material_200_percent/mac/bookmark_bar_folder.png View Binary file 0 comments Download
A chrome/app/theme/material_200_percent/mac/bookmark_bar_folder_managed.png View Binary file 0 comments Download
A chrome/app/theme/material_200_percent/mac/bookmark_bar_folder_supervised.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_constants.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h View 5 chunks +19 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 34 chunks +203 lines, -69 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 5 chunks +85 lines, -26 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 7 chunks +12 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm View 5 chunks +43 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 5 chunks +98 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell.mm View 9 chunks +93 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
qyearsley
Created Reland of [Mac][Material Design] Update bookmarks bar to Material Design.
4 years, 7 months ago (2016-05-17 23:50:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987893002/1
4 years, 7 months ago (2016-05-17 23:51:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 23:52:18 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 23:54:06 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e83b1122b753bc3069bf1f59610d09970f9051e3
Cr-Commit-Position: refs/heads/master@{#394270}

Powered by Google App Engine
This is Rietveld 408576698