[remoting host] Add User-Agent to third-party cert validation requests.

[remoting host] Add User-Agent to third-party cert validation requests.

This sets the User-Agent to the application name (Chromoting or
Chrome Remote Desktop) and version number.

BUG=611107
Committed: https://crrev.com/4bacbb1c3ee8c1a0978e10bfe8e5c921ed775354
Cr-Commit-Position: refs/heads/master@{#394507}

[Lambros, 2016-05-17 21:35:20]

lambroslambrou@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Lambros, 2016-05-17 21:35:21]

Maybe this should go in remoting/host/branding.[cc,h] or somewhere else?

[Sergey Ulanov, 2016-05-18 07:11:03]

lgtm after my comments are addressed

https://codereview.chromium.org/1987863002/diff/1/remoting/host/token_validat...
File remoting/host/token_validator_factory_impl.cc (right):

https://codereview.chromium.org/1987863002/diff/1/remoting/host/token_validat...
remoting/host/token_validator_factory_impl.cc:96: #define APP_NAME "Chrome
Remote Desktop"
Don't need to use #define here.
std::string app_name = "Chrome Remote Desktop";

https://codereview.chromium.org/1987863002/diff/1/remoting/host/token_validat...
remoting/host/token_validator_factory_impl.cc:101: APP_NAME " "
STRINGIZE(VERSION), true);
Add a check that VERSION is defined:
#ifndef VERSION
 #error
#endif

[Lambros, 2016-05-18 18:49:03]

Patchset #2 (id:20001) has been deleted

[Lambros, 2016-05-18 18:49:44]

https://codereview.chromium.org/1987863002/diff/1/remoting/host/token_validat...
File remoting/host/token_validator_factory_impl.cc (right):

https://codereview.chromium.org/1987863002/diff/1/remoting/host/token_validat...
remoting/host/token_validator_factory_impl.cc:96: #define APP_NAME "Chrome
Remote Desktop"
On 2016/05/18 07:11:02, Sergey Ulanov wrote:
> Don't need to use #define here.
> std::string app_name = "Chrome Remote Desktop";

Done.

https://codereview.chromium.org/1987863002/diff/1/remoting/host/token_validat...
remoting/host/token_validator_factory_impl.cc:101: APP_NAME " "
STRINGIZE(VERSION), true);
On 2016/05/18 07:11:02, Sergey Ulanov wrote:
> Add a check that VERSION is defined:
> #ifndef VERSION
>  #error
> #endif

Done. (git cl format removes indentation of #error)

[Lambros, 2016-05-18 18:49:50]

The CQ bit was checked by lambroslambrou@chromium.org

[Lambros, 2016-05-18 18:49:50]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1987863002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-05-18 18:50:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987863002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987863002/40001

[commit-bot: I haz the power, 2016-05-18 19:38:39]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-18 19:40:47]

Description was changed from

==========
[remoting host] Add User-Agent to third-party cert validation requests.

This sets the User-Agent to the application name (Chromoting or
Chrome Remote Desktop) and version number.

BUG=611107
==========

to

==========
[remoting host] Add User-Agent to third-party cert validation requests.

This sets the User-Agent to the application name (Chromoting or
Chrome Remote Desktop) and version number.

BUG=611107

Committed: https://crrev.com/4bacbb1c3ee8c1a0978e10bfe8e5c921ed775354
Cr-Commit-Position: refs/heads/master@{#394507}
==========

[commit-bot: I haz the power, 2016-05-18 19:40:48]

Patchset 2 (id:??) landed as
https://crrev.com/4bacbb1c3ee8c1a0978e10bfe8e5c921ed775354
Cr-Commit-Position: refs/heads/master@{#394507}