Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: Source/core/css/SelectorChecker.cpp

Issue 198783003: Recalc sibling styles for forward positional rules on mutations only. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed review issue. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/css/nth-child-no-mutations-expected.txt ('k') | Source/core/dom/Element.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 nextContext.element = ElementTraversal::previousSibling(*context.element ); 286 nextContext.element = ElementTraversal::previousSibling(*context.element );
287 if (!nextContext.element) 287 if (!nextContext.element)
288 return SelectorFailsAllSiblings; 288 return SelectorFailsAllSiblings;
289 nextContext.isSubSelector = false; 289 nextContext.isSubSelector = false;
290 nextContext.elementStyle = 0; 290 nextContext.elementStyle = 0;
291 return match(nextContext, siblingTraversalStrategy, result); 291 return match(nextContext, siblingTraversalStrategy, result);
292 292
293 case CSSSelector::IndirectAdjacent: 293 case CSSSelector::IndirectAdjacent:
294 if (m_mode == ResolvingStyle) { 294 if (m_mode == ResolvingStyle) {
295 if (Node* parent = context.element->parentElementOrShadowRoot()) 295 if (Node* parent = context.element->parentElementOrShadowRoot())
296 SiblingRuleHelper(parent).setChildrenAffectedByForwardPositional Rules(); 296 SiblingRuleHelper(parent).setChildrenAffectedByIndirectAdjacentR ules();
297 } 297 }
298 nextContext.element = ElementTraversal::previousSibling(*context.element ); 298 nextContext.element = ElementTraversal::previousSibling(*context.element );
299 nextContext.isSubSelector = false; 299 nextContext.isSubSelector = false;
300 nextContext.elementStyle = 0; 300 nextContext.elementStyle = 0;
301 for (; nextContext.element; nextContext.element = ElementTraversal::prev iousSibling(*nextContext.element)) { 301 for (; nextContext.element; nextContext.element = ElementTraversal::prev iousSibling(*nextContext.element)) {
302 Match match = this->match(nextContext, siblingTraversalStrategy, res ult); 302 Match match = this->match(nextContext, siblingTraversalStrategy, res ult);
303 if (match == SelectorMatches || match == SelectorFailsAllSiblings || match == SelectorFailsCompletely) 303 if (match == SelectorMatches || match == SelectorFailsAllSiblings || match == SelectorFailsCompletely)
304 return match; 304 return match;
305 }; 305 };
306 return SelectorFailsAllSiblings; 306 return SelectorFailsAllSiblings;
(...skipping 794 matching lines...) Expand 10 before | Expand all | Expand 10 after
1101 return element.focused() && isFrameFocused(element); 1101 return element.focused() && isFrameFocused(element);
1102 } 1102 }
1103 1103
1104 template 1104 template
1105 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst DOMSiblingTraversalStrategy&, MatchResult*) const; 1105 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst DOMSiblingTraversalStrategy&, MatchResult*) const;
1106 1106
1107 template 1107 template
1108 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst ShadowDOMSiblingTraversalStrategy&, MatchResult*) const; 1108 SelectorChecker::Match SelectorChecker::match(const SelectorCheckingContext&, co nst ShadowDOMSiblingTraversalStrategy&, MatchResult*) const;
1109 1109
1110 } 1110 }
OLDNEW
« no previous file with comments | « LayoutTests/fast/css/nth-child-no-mutations-expected.txt ('k') | Source/core/dom/Element.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698