Remove Windows Vista/XP specific code from net/cert and net/ssl.

Remove Windows Vista/XP specific code from net/cert and net/ssl.

BUG=580691
Committed: https://crrev.com/274a3f4200baf362cdcaabf46f69b535995ba2eb
Cr-Commit-Position: refs/heads/master@{#395057}

[martijnc, 2016-05-17 17:47:12]

Description was changed from

==========
Remove Windows Vista/XP specific code from net/cert.

BUG=580691
==========

to

==========
Remove Windows Vista/XP specific code from net/cert and net/ssl.

BUG=580691
==========

[martijnc, 2016-05-17 17:47:12]

martijn@martijnc.be changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2016-05-17 20:23:06]

Did you mean to publish this for review?

[martijnc, 2016-05-17 20:24:22]

Patchset #2 (id:20001) has been deleted

[martijnc, 2016-05-17 20:26:00]

On 2016/05/17 at 20:23:06, rsleevi wrote:
> Did you mean to publish this for review?

Not yet, there is a problem with PS1 I have to fix first.

[Ryan Sleevi, 2016-05-17 20:26:01]

https://codereview.chromium.org/1987793002/diff/40001/net/cert/test_root_cert...
File net/cert/test_root_certs_win.cc (right):

https://codereview.chromium.org/1987793002/diff/40001/net/cert/test_root_cert...
net/cert/test_root_certs_win.cc:182: CERT_CHAIN_ENGINE_CONFIG engine_config =
{sizeof(CERT_CHAIN_ENGINE_CONFIG)};
CERT_CHAIN_ENGINE_CONFIG engine_config = {0};
engine_config.dwSize = sizeof(engine_config);

Is the more idiomatic form.

[martijnc, 2016-05-17 21:23:43]

Patchset #3 (id:60001) has been deleted

[martijnc, 2016-05-17 21:29:11]

Patchset #1 (id:1) has been deleted

[martijnc, 2016-05-18 18:49:43]

Patchset #2 (id:80001) has been deleted

[martijnc, 2016-05-18 18:51:56]

Patchset #2 (id:100001) has been deleted

[martijnc, 2016-05-18 21:32:10]

Patchset #2 (id:120001) has been deleted

[martijnc, 2016-05-19 21:27:33]

This now ready for review. Can you take a look? Thanks!

(some of the changes in PS1 were included in another CL that crossed mine)

https://codereview.chromium.org/1987793002/diff/40001/net/cert/test_root_cert...
File net/cert/test_root_certs_win.cc (right):

https://codereview.chromium.org/1987793002/diff/40001/net/cert/test_root_cert...
net/cert/test_root_certs_win.cc:182: CERT_CHAIN_ENGINE_CONFIG engine_config =
{sizeof(CERT_CHAIN_ENGINE_CONFIG)};
On 2016/05/17 at 20:26:01, Ryan Sleevi wrote:
> CERT_CHAIN_ENGINE_CONFIG engine_config = {0};
> engine_config.dwSize = sizeof(engine_config);
> 
> Is the more idiomatic form.

I kept the old code but included the 2 fields that were added in Windows 7.
Using sizeof() doesn't seem to work (because of the Windows 8+ field?).

[Ryan Sleevi, 2016-05-19 22:17:29]

lgtm

[martijnc, 2016-05-20 11:02:31]

The CQ bit was checked by martijn@martijnc.be

[commit-bot: I haz the power, 2016-05-20 11:02:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987793002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987793002/160001

[commit-bot: I haz the power, 2016-05-20 11:50:15]

Committed patchset #3 (id:160001)

[commit-bot: I haz the power, 2016-05-20 11:52:03]

Description was changed from

==========
Remove Windows Vista/XP specific code from net/cert and net/ssl.

BUG=580691
==========

to

==========
Remove Windows Vista/XP specific code from net/cert and net/ssl.

BUG=580691

Committed: https://crrev.com/274a3f4200baf362cdcaabf46f69b535995ba2eb
Cr-Commit-Position: refs/heads/master@{#395057}
==========

[commit-bot: I haz the power, 2016-05-20 11:52:04]

Patchset 3 (id:??) landed as
https://crrev.com/274a3f4200baf362cdcaabf46f69b535995ba2eb
Cr-Commit-Position: refs/heads/master@{#395057}