Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1987783002: Revert of Remove an unnecessary variable from CPDF_Creator (Closed)

Created:
4 years, 7 months ago by Wei Li
Modified:
4 years, 7 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Remove an unnecessary variable from CPDF_Creator (patchset #1 id:20001 of https://codereview.chromium.org/1988603002/ ) Reason for revert: The variable is still needed, will fix the other way. Original issue's description: > Remove an unnecessary variable from CPDF_Creator > > The variable may not be initialized before using, which caused > errors on DrMemory bot. Since it is not necessary, remove it. > > TBR=thestig@chromium.org > > Committed: https://pdfium.googlesource.com/pdfium/+/47b998b53edbb071bb55c909169be1070126fb22 TBR=dsinclair@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/dd427007f2c44b10752e7ee3101c9785f1e46c15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 3 chunks +8 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_edit/include/cpdf_creator.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Wei Li
Created Revert of Remove an unnecessary variable from CPDF_Creator
4 years, 7 months ago (2016-05-17 16:33:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987783002/1
4 years, 7 months ago (2016-05-17 16:33:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/dd427007f2c44b10752e7ee3101c9785f1e46c15
4 years, 7 months ago (2016-05-17 16:33:39 UTC) #4
dsinclair
4 years, 7 months ago (2016-05-17 16:37:06 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698