Revert arm_fpu flags for arm64

Revert arm_fpu flags for arm64

Tried to set arm_fpu to "cortex-a57+simd+crypto+fp+crc" for clang

These lines also affect GCC which is used to ship official chrome,
All ARMv8 implementations would support SIMD and FP by default, but
crypto is optional, so the code generated might fail on devices which
do not support crypto also adding cortex-a57 and using on cortex-a53
or vice versa might generate code that is going to be slower.

So we decided to revert this patch.

BUG : http://crbug.com/539781

BUG=539781
R=thakis@chromium.org
TEST=download apk to ARMv8 board and launch

Committed: https://crrev.com/5d3069f38c1bbacbfc9d1ef672ea8c8dc9d12b3f
Cr-Commit-Position: refs/heads/master@{#394334}

[Nico, 2016-05-17 16:31:44]

Thanks! We don't usually put "Signed-off by:" lines into our commit messages.

https://codereview.chromium.org/1987733002/diff/1/build/config/compiler/BUILD.gn
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1987733002/diff/1/build/config/compiler/BUILD...
build/config/compiler/BUILD.gn:733: asmflags = cflags
you can just remove the whole else if block now, right?

[khasim.mohammed, 2016-05-18 02:14:32]

On 2016/05/17 16:31:44, Nico (vacation May 19 to 22) wrote:
> Thanks! We don't usually put "Signed-off by:" lines into our commit messages.
> 
>
https://codereview.chromium.org/1987733002/diff/1/build/config/compiler/BUILD.gn
> File build/config/compiler/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1987733002/diff/1/build/config/compiler/BUILD...
> build/config/compiler/BUILD.gn:733: asmflags = cflags
> you can just remove the whole else if block now, right?

Removed else block completely in patch set 2

[Nico, 2016-05-18 02:29:51]

lgtm

[Nico, 2016-05-18 02:30:06]

Description was changed from

==========
Revert arm_fpu flags for arm64

Tried to set arm_fpu to "cortex-a57+simd+crypto+fp+crc" for clang

These lines also affect GCC which is used to ship official chrome,
All ARMv8 implementations would support SIMD and FP by default, but
crypto is optional, so the code generated might fail on devices which
do not support crypto also adding cortex-a57 and using on cortex-a53
or vice versa might generate code that is going to be slower.

So we decided to revert this patch.

BUG : http://crbug.com/539781

Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@linaro.org>

BUG=539781
R=thakis@chromium.org
TEST=download apk to ARMv8 board and launch
==========

to

==========
Revert arm_fpu flags for arm64

Tried to set arm_fpu to "cortex-a57+simd+crypto+fp+crc" for clang

These lines also affect GCC which is used to ship official chrome,
All ARMv8 implementations would support SIMD and FP by default, but
crypto is optional, so the code generated might fail on devices which
do not support crypto also adding cortex-a57 and using on cortex-a53
or vice versa might generate code that is going to be slower.

So we decided to revert this patch.

BUG : http://crbug.com/539781

BUG=539781
R=thakis@chromium.org
TEST=download apk to ARMv8 board and launch
==========

[Nico, 2016-05-18 02:30:12]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-05-18 02:30:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987733002/20001

[khasim.mohammed, 2016-05-18 03:40:13]

The CQ bit was unchecked by khasim.mohammed@linaro.org

[khasim.mohammed, 2016-05-18 03:40:13]

The CQ bit was checked by khasim.mohammed@linaro.org

[commit-bot: I haz the power, 2016-05-18 03:40:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987733002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987733002/20001

[commit-bot: I haz the power, 2016-05-18 04:20:27]

Description was changed from

==========
Revert arm_fpu flags for arm64

Tried to set arm_fpu to "cortex-a57+simd+crypto+fp+crc" for clang

These lines also affect GCC which is used to ship official chrome,
All ARMv8 implementations would support SIMD and FP by default, but
crypto is optional, so the code generated might fail on devices which
do not support crypto also adding cortex-a57 and using on cortex-a53
or vice versa might generate code that is going to be slower.

So we decided to revert this patch.

BUG : http://crbug.com/539781

BUG=539781
R=thakis@chromium.org
TEST=download apk to ARMv8 board and launch
==========

to

==========
Revert arm_fpu flags for arm64

Tried to set arm_fpu to "cortex-a57+simd+crypto+fp+crc" for clang

These lines also affect GCC which is used to ship official chrome,
All ARMv8 implementations would support SIMD and FP by default, but
crypto is optional, so the code generated might fail on devices which
do not support crypto also adding cortex-a57 and using on cortex-a53
or vice versa might generate code that is going to be slower.

So we decided to revert this patch.

BUG : http://crbug.com/539781

BUG=539781
R=thakis@chromium.org
TEST=download apk to ARMv8 board and launch
==========

[commit-bot: I haz the power, 2016-05-18 04:20:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-18 04:21:36]

Description was changed from

==========
Revert arm_fpu flags for arm64

Tried to set arm_fpu to "cortex-a57+simd+crypto+fp+crc" for clang

These lines also affect GCC which is used to ship official chrome,
All ARMv8 implementations would support SIMD and FP by default, but
crypto is optional, so the code generated might fail on devices which
do not support crypto also adding cortex-a57 and using on cortex-a53
or vice versa might generate code that is going to be slower.

So we decided to revert this patch.

BUG : http://crbug.com/539781

BUG=539781
R=thakis@chromium.org
TEST=download apk to ARMv8 board and launch
==========

to

==========
Revert arm_fpu flags for arm64

Tried to set arm_fpu to "cortex-a57+simd+crypto+fp+crc" for clang

These lines also affect GCC which is used to ship official chrome,
All ARMv8 implementations would support SIMD and FP by default, but
crypto is optional, so the code generated might fail on devices which
do not support crypto also adding cortex-a57 and using on cortex-a53
or vice versa might generate code that is going to be slower.

So we decided to revert this patch.

BUG : http://crbug.com/539781

BUG=539781
R=thakis@chromium.org
TEST=download apk to ARMv8 board and launch

Committed: https://crrev.com/5d3069f38c1bbacbfc9d1ef672ea8c8dc9d12b3f
Cr-Commit-Position: refs/heads/master@{#394334}
==========

[commit-bot: I haz the power, 2016-05-18 04:21:37]

Patchset 2 (id:??) landed as
https://crrev.com/5d3069f38c1bbacbfc9d1ef672ea8c8dc9d12b3f
Cr-Commit-Position: refs/heads/master@{#394334}

[khasim.mohammed, 2016-05-19 05:48:50]

Patchset #3 (id:40001) has been deleted