Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 198773002: Disable ASan instrumentation for globals on Mac to work around issue 352073 (Closed)

Created:
6 years, 9 months ago by Alexander Potapenko
Modified:
6 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Disable ASan instrumentation for globals on Mac to work around issue 352073 BUG=352073 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M build/common.gypi View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexander Potapenko
TBR
6 years, 9 months ago (2014-03-13 08:39:56 UTC) #1
Alexander Potapenko
The CQ bit was checked by glider@chromium.org
6 years, 9 months ago (2014-03-13 08:40:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/198773002/1
6 years, 9 months ago (2014-03-13 08:40:16 UTC) #3
commit-bot: I haz the power
Change committed as 256799
6 years, 9 months ago (2014-03-13 10:55:10 UTC) #4
Nico
6 years, 9 months ago (2014-03-13 15:56:27 UTC) #5
Message was sent while issue was closed.
lgtm

Nice work tracking this down :-)

Powered by Google App Engine
This is Rietveld 408576698