Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1987723002: Speed up global tool (Closed)

Created:
4 years, 7 months ago by vsm
Modified:
4 years, 7 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Speed up global tool Use parsedirectives instead of resolution - this is much faster. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/ac641ee42fbe56abb7db5483a5a2fd00ff181924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -26 lines) Patch
M tool/global_compile.dart View 3 chunks +41 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 7 months ago (2016-05-17 15:30:45 UTC) #3
Leaf
lgtm
4 years, 7 months ago (2016-05-17 15:39:10 UTC) #4
vsm
4 years, 7 months ago (2016-05-17 16:29:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ac641ee42fbe56abb7db5483a5a2fd00ff181924 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698