Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1987643003:
Fix to prevent hitting NOTREACHED in FrameTreeNode::PreviousSibling(). (Closed)
|
Created:
4 years, 7 months ago by paulmeyer Modified:
4 years, 7 months ago Reviewers:
ncarter (slow) CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix to prevent hitting NOTREACHED in FrameTreeNode::PreviousSibling().
BUG=612450
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/f3119f5f25a242c2c36a58f32ef13328f13712cb
Cr-Commit-Position: refs/heads/master@{#394156}
Patch Set 1 #Patch Set 2 : Rebased. #Messages
Total messages: 20 (10 generated)
Description was changed from ========== Fix to prevent hitting NOTREACHED in FrameTreeNode::PreviousSibling(). BUG=612450 ========== to ========== Fix to prevent hitting NOTREACHED in FrameTreeNode::PreviousSibling(). BUG=612450 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by paulmeyer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987643003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
The CQ bit was checked by paulmeyer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987643003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987643003/20001
+nick@
Description was changed from ========== Fix to prevent hitting NOTREACHED in FrameTreeNode::PreviousSibling(). BUG=612450 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix to prevent hitting NOTREACHED in FrameTreeNode::PreviousSibling(). BUG=612450 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ==========
creis@chromium.org changed reviewers: + nick@chromium.org
On 2016/05/17 16:07:13, paulmeyer wrote: > +nick@ [Adding Nick for real]
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by paulmeyer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987643003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987643003/20001
Message was sent while issue was closed.
Description was changed from ========== Fix to prevent hitting NOTREACHED in FrameTreeNode::PreviousSibling(). BUG=612450 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix to prevent hitting NOTREACHED in FrameTreeNode::PreviousSibling(). BUG=612450 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix to prevent hitting NOTREACHED in FrameTreeNode::PreviousSibling(). BUG=612450 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== Fix to prevent hitting NOTREACHED in FrameTreeNode::PreviousSibling(). BUG=612450 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/f3119f5f25a242c2c36a58f32ef13328f13712cb Cr-Commit-Position: refs/heads/master@{#394156} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f3119f5f25a242c2c36a58f32ef13328f13712cb Cr-Commit-Position: refs/heads/master@{#394156} |
