Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1525)

Unified Diff: content/browser/renderer_host/media/audio_renderer_host.cc

Issue 1987643002: Make default media device ID salts random by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change return type from const string to string as it makes no difference Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_renderer_host.cc
diff --git a/content/browser/renderer_host/media/audio_renderer_host.cc b/content/browser/renderer_host/media/audio_renderer_host.cc
index 0cf02958b073e8ae8218f66ad09a305215a643e7..947c00cd4331e84959852f61e8023fffb8a00680 100644
--- a/content/browser/renderer_host/media/audio_renderer_host.cc
+++ b/content/browser/renderer_host/media/audio_renderer_host.cc
@@ -194,13 +194,12 @@ AudioRendererHost::AudioEntry::~AudioEntry() {}
///////////////////////////////////////////////////////////////////////////////
// AudioRendererHost implementations.
-AudioRendererHost::AudioRendererHost(
- int render_process_id,
- media::AudioManager* audio_manager,
- AudioMirroringManager* mirroring_manager,
- MediaInternals* media_internals,
- MediaStreamManager* media_stream_manager,
- const ResourceContext::SaltCallback& salt_callback)
+AudioRendererHost::AudioRendererHost(int render_process_id,
+ media::AudioManager* audio_manager,
+ AudioMirroringManager* mirroring_manager,
+ MediaInternals* media_internals,
+ MediaStreamManager* media_stream_manager,
+ const std::string& salt)
: BrowserMessageFilter(AudioMsgStart),
render_process_id_(render_process_id),
audio_manager_(audio_manager),
@@ -209,7 +208,7 @@ AudioRendererHost::AudioRendererHost(
media::AudioLogFactory::AUDIO_OUTPUT_CONTROLLER)),
media_stream_manager_(media_stream_manager),
num_playing_streams_(0),
- salt_callback_(salt_callback),
+ salt_(salt),
max_simultaneous_streams_(0) {
DCHECK(audio_manager_);
DCHECK(media_stream_manager_);
@@ -436,7 +435,7 @@ void AudioRendererHost::OnRequestDeviceAuthorization(
// Hash matched device id and pass it to the renderer
Send(new AudioMsg_NotifyDeviceAuthorized(
stream_id, media::OUTPUT_DEVICE_STATUS_OK, output_params,
- GetHMACForMediaDeviceID(salt_callback_, security_origin,
+ GetHMACForMediaDeviceID(salt_, security_origin,
info->device.matched_output_device_id)));
return;
}
@@ -795,9 +794,8 @@ void AudioRendererHost::TranslateDeviceID(
callback.Run(true, device_info);
return;
}
- } else if (content::DoesMediaDeviceIDMatchHMAC(salt_callback_,
- security_origin, device_id,
- device_info.unique_id)) {
+ } else if (content::DoesMediaDeviceIDMatchHMAC(
+ salt_, security_origin, device_id, device_info.unique_id)) {
callback.Run(true, device_info);
return;
}

Powered by Google App Engine
This is Rietveld 408576698