chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc - Issue 1987643002: Make default media device ID salts random by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

Issue 1987643002: Make default media device ID salts random by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change return type from const string to string as it makes no difference Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h ('k') | chrome/browser/media/media_device_id_salt.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

index e4e11b9be4a8a8f87e59c9ee50c9ff45554e4549..8c55a9c01c6fdfddf0bc78a197c43481b710bba9 100644

--- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

+++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

@@ -5,6 +5,7 @@

#include "chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h"

#include <utility>

+#include <vector>

#include "base/lazy_instance.h"

#include "base/memory/ptr_util.h"

@@ -209,9 +210,7 @@ void WebrtcAudioPrivateFunction::InitDeviceIDSalt() {

device_id_salt_ = GetProfile()->GetResourceContext()->GetMediaDeviceIDSalt();

}

-const content::ResourceContext::SaltCallback&

-WebrtcAudioPrivateFunction::device_id_salt() const {

- DCHECK(!device_id_salt_.is_null());

+std::string WebrtcAudioPrivateFunction::device_id_salt() const {

return device_id_salt_;

}