Make default media device ID salts random by default

chrome/browser/profiles/profile_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_io_data.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <utility>
@@ skipping 481 matching lines @@
         prefs::kGoogleServicesUserAccountId, pref_service);
     google_services_user_account_id_.MoveToThread(io_task_runner);
 
     sync_disabled_.Init(sync_driver::prefs::kSyncManaged, pref_service);
     sync_disabled_.MoveToThread(io_task_runner);
 
     signin_allowed_.Init(prefs::kSigninAllowed, pref_service);
     signin_allowed_.MoveToThread(io_task_runner);
   }
 
-  media_device_id_salt_ = new MediaDeviceIDSalt(pref_service, IsOffTheRecord());
+  if (!IsOffTheRecord())
+    media_device_id_salt_ = new MediaDeviceIDSalt(pref_service);
 
   network_prediction_options_.Init(prefs::kNetworkPredictionOptions,
                                    pref_service);
 
   network_prediction_options_.MoveToThread(io_task_runner);
 
 #if defined(OS_CHROMEOS)
   std::unique_ptr<policy::PolicyCertVerifier> verifier =
       policy::PolicyCertServiceFactory::CreateForProfile(profile);
   policy_cert_verifier_ = verifier.get();
@@ skipping 345 matching lines @@
   // Allow either Init() or SetCookieSettingsForTesting() to initialize.
   DCHECK(initialized_ || cookie_settings_.get());
   return cookie_settings_.get();
 }
 
 HostContentSettingsMap* ProfileIOData::GetHostContentSettingsMap() const {
   DCHECK(initialized_);
   return host_content_settings_map_.get();
 }
 
-ResourceContext::SaltCallback ProfileIOData::GetMediaDeviceIDSalt() const {
-  return base::Bind(&MediaDeviceIDSalt::GetSalt, media_device_id_salt_);
+std::string ProfileIOData::GetMediaDeviceIDSalt() const {
+  DCHECK(media_device_id_salt_);
+  return media_device_id_salt_->GetSalt();
 }
 
 bool ProfileIOData::IsOffTheRecord() const {
   return profile_type() == Profile::INCOGNITO_PROFILE
       || profile_type() == Profile::GUEST_PROFILE;
 }
 
 void ProfileIOData::InitializeMetricsEnabledStateOnUIThread() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 #if BUILDFLAG(ANDROID_JAVA_UI)
@@ skipping 116 matching lines @@
       chrome::kCryptoModulePasswordKeygen,
       net::HostPortPair::FromURL(url),
       this,
       got_delegate_callback);
 #else
   callback.Run(base::WrapUnique(
       new net::KeygenHandler(key_size_in_bits, challenge_string, url)));
 #endif
 }
 
-ResourceContext::SaltCallback
-ProfileIOData::ResourceContext::GetMediaDeviceIDSalt() {
-  return io_data_->GetMediaDeviceIDSalt();
+std::string ProfileIOData::ResourceContext::GetMediaDeviceIDSalt() {
+  if (io_data_->HasMediaDeviceIDSalt())
+    return io_data_->GetMediaDeviceIDSalt();
+
+  return content::ResourceContext::GetMediaDeviceIDSalt();
 }
 
 void ProfileIOData::Init(
     content::ProtocolHandlerMap* protocol_handlers,
     content::URLRequestInterceptorScopedVector request_interceptors) const {
   // The basic logic is implemented here. The specific initialization
   // is done in InitializeInternal(), implemented by subtypes. Static helper
   // functions have been provided to assist in common operations.
   DCHECK_CURRENTLY_ON(BrowserThread::IO);
   DCHECK(!initialized_);
@@ skipping 336 matching lines @@
 void ProfileIOData::SetCookieSettingsForTesting(
     content_settings::CookieSettings* cookie_settings) {
   DCHECK(!cookie_settings_.get());
   cookie_settings_ = cookie_settings;
 }
 
 policy::URLBlacklist::URLBlacklistState ProfileIOData::GetURLBlacklistState(
     const GURL& url) const {
   return url_blacklist_manager_->GetURLBlacklistState(url);
 }