Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: chrome/browser/media/media_device_id_salt.h

Issue 1987643002: Make default media device ID salts random by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: change return type from const string to string as it makes no difference Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_MEDIA_MEDIA_DEVICE_ID_SALT_H_ 5 #ifndef CHROME_BROWSER_MEDIA_MEDIA_DEVICE_ID_SALT_H_
6 #define CHROME_BROWSER_MEDIA_MEDIA_DEVICE_ID_SALT_H_ 6 #define CHROME_BROWSER_MEDIA_MEDIA_DEVICE_ID_SALT_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "components/pref_registry/pref_registry_syncable.h" 12 #include "components/pref_registry/pref_registry_syncable.h"
13 #include "components/prefs/pref_member.h" 13 #include "components/prefs/pref_member.h"
14 14
15 class PrefService; 15 class PrefService;
16 16
17 // MediaDeviceIDSalt is responsible for creating and retrieving a salt string 17 // MediaDeviceIDSalt is responsible for creating and retrieving a salt string
18 // that is used for creating MediaSource IDs that can be cached by a web 18 // that is used for creating MediaSource IDs that can be cached by a web
19 // service. If the cache is cleared, the MediaSourceIds are invalidated. 19 // service. If the cache is cleared, the MediaSourceIds are invalidated.
20 // 20 //
21 // The class is reference counted so that it can be used in the 21 // The class is reference counted so that it can be used in the
22 // callback returned by ResourceContext::GetMediaDeviceIDSalt. 22 // callback returned by ResourceContext::GetMediaDeviceIDSalt.
23 class MediaDeviceIDSalt : public base::RefCountedThreadSafe<MediaDeviceIDSalt> { 23 class MediaDeviceIDSalt : public base::RefCountedThreadSafe<MediaDeviceIDSalt> {
24 public: 24 public:
25 MediaDeviceIDSalt(PrefService* pref_service, bool incognito); 25 explicit MediaDeviceIDSalt(PrefService* pref_service);
26 void ShutdownOnUIThread(); 26 void ShutdownOnUIThread();
27 27
28 std::string GetSalt() const; 28 std::string GetSalt() const;
29 29
30 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry); 30 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
31 static void Reset(PrefService* pref_service); 31 static void Reset(PrefService* pref_service);
32 32
33 private: 33 private:
34 friend class base::RefCountedThreadSafe<MediaDeviceIDSalt>; 34 friend class base::RefCountedThreadSafe<MediaDeviceIDSalt>;
35 ~MediaDeviceIDSalt(); 35 ~MediaDeviceIDSalt();
36 36
37 // |incognito_salt_| is initialized in ctor on UI thread but only read
38 // on the IO thread.
39 std::string incognito_salt_;
40 mutable StringPrefMember media_device_id_salt_; 37 mutable StringPrefMember media_device_id_salt_;
41 38
42 DISALLOW_COPY_AND_ASSIGN(MediaDeviceIDSalt); 39 DISALLOW_COPY_AND_ASSIGN(MediaDeviceIDSalt);
43 }; 40 };
44 41
45 #endif // CHROME_BROWSER_MEDIA_MEDIA_DEVICE_ID_SALT_H_ 42 #endif // CHROME_BROWSER_MEDIA_MEDIA_DEVICE_ID_SALT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698