Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1987633002: Remove Windows Vista/XP specific code from net/cert. (Closed)

Created:
4 years, 7 months ago by maksims (do not use this acc)
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Windows Vista/XP specific code from net/cert. Changes to unittests. BUG=580691 Committed: https://crrev.com/95e711a2e73ffd4d5029206deeb71d3624754902 Cr-Commit-Position: refs/heads/master@{#394700}

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : Oops, missed some comments. Fixed! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M net/cert/cert_verify_proc_unittest.cc View 1 2 2 chunks +2 lines, -11 lines 0 comments Download
M net/cert/x509_certificate_unittest.cc View 1 2 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
maksims (do not use this acc)
ptal
4 years, 7 months ago (2016-05-17 10:54:19 UTC) #3
mmenke
https://codereview.chromium.org/1987633002/diff/1/net/cert/cert_verify_proc_unittest.cc File net/cert/cert_verify_proc_unittest.cc (right): https://codereview.chromium.org/1987633002/diff/1/net/cert/cert_verify_proc_unittest.cc#newcode33 net/cert/cert_verify_proc_unittest.cc:33: #include "base/win/windows_version.h" Header no longer needed. https://codereview.chromium.org/1987633002/diff/1/net/cert/cert_verify_proc_unittest.cc#newcode361 net/cert/cert_verify_proc_unittest.cc:361: bool ...
4 years, 7 months ago (2016-05-17 11:26:37 UTC) #4
mmenke
Oops, forgot one. https://codereview.chromium.org/1987633002/diff/1/net/cert/x509_certificate_unittest.cc File net/cert/x509_certificate_unittest.cc (right): https://codereview.chromium.org/1987633002/diff/1/net/cert/x509_certificate_unittest.cc#newcode32 net/cert/x509_certificate_unittest.cc:32: #endif No longer needed
4 years, 7 months ago (2016-05-17 11:27:08 UTC) #5
maksims (do not use this acc)
On 2016/05/17 11:27:08, mmenke wrote: > Oops, forgot one. > > https://codereview.chromium.org/1987633002/diff/1/net/cert/x509_certificate_unittest.cc > File net/cert/x509_certificate_unittest.cc ...
4 years, 7 months ago (2016-05-17 11:29:06 UTC) #6
mmenke
On 2016/05/17 11:29:06, maksims wrote: > On 2016/05/17 11:27:08, mmenke wrote: > > Oops, forgot ...
4 years, 7 months ago (2016-05-17 12:41:55 UTC) #7
maksims (do not use this acc)
Kindly as for a further review. https://codereview.chromium.org/1987633002/diff/1/net/cert/cert_verify_proc_unittest.cc File net/cert/cert_verify_proc_unittest.cc (right): https://codereview.chromium.org/1987633002/diff/1/net/cert/cert_verify_proc_unittest.cc#newcode33 net/cert/cert_verify_proc_unittest.cc:33: #include "base/win/windows_version.h" On ...
4 years, 7 months ago (2016-05-18 06:46:21 UTC) #8
mmenke
LGTM! Thanks for doing this!
4 years, 7 months ago (2016-05-18 16:23:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987633002/40001
4 years, 7 months ago (2016-05-19 05:45:34 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-19 06:39:34 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 06:40:59 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95e711a2e73ffd4d5029206deeb71d3624754902
Cr-Commit-Position: refs/heads/master@{#394700}

Powered by Google App Engine
This is Rietveld 408576698