third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp - Issue 1987613002: [DevTools Capture call stacks for XHR console messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 1987613002: [DevTools Capture call stacks for XHR console messages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

diff --git a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

index 087a2151bfe09c7214741bf69ca86dd1045bd3e2..f4a5a3b460d0b4ec9859bb05124b762d8d3f8293 100644

--- a/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

+++ b/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

@@ -126,7 +126,9 @@ void logConsoleError(ExecutionContext* context, const String& message)

return;

// FIXME: It's not good to report the bad usage without indicating what source line it came from.

pfeldman 2016/05/17 17:19:42 Do we still need this comment?

// We should pass additional parameters so we can tell the console where the mistake occurred.

- context->addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message));

+ ConsoleMessage* consoleMessage = ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message);

+ consoleMessage->collectCallStack();

+ context->addConsoleMessage(consoleMessage);

}

enum HeaderValueCategoryByRFC7230 {