[DurableStorage] Add UseCounter and fixed IDL

[DurableStorage] Add UseCounter and fixed IDL

This adds use counters to the durable storage StorageManager javascript
API, and also switches the feature runtime flag to OriginTrialEnabled
instead of RuntimeEnabled.

BUG=610500
Committed: https://crrev.com/90df253575a992dadeefd82e95069a24281cc1a1
Cr-Commit-Position: refs/heads/master@{#394339}

[dmurph, 2016-05-17 00:36:56]

dmurph@chromium.org changed reviewers:
+ chasej@chromium.org

[dmurph, 2016-05-17 00:36:57]

Hi Jason,

Is this what you meant? Can you PTAL?

Thanks!
Daniel

[chasej, 2016-05-17 03:00:43]

LGTM.

https://codereview.chromium.org/1987563002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/quota/StorageManager.idl (right):

https://codereview.chromium.org/1987563002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/quota/StorageManager.idl:14:
[RuntimeEnabled=StorageEstimate, CallWith=ScriptState,
MeasureAs=DurableStorageEstimate] Promise<StorageEstimate> estimate();
Given that estimate() isn't being exposed as part of the origin trial, this
method doesn't need [MeasureAs] for that reason. I think it's certainly
reasonable to add it now. I'm just mentioning in case there was confusion.

[dmurph, 2016-05-17 18:43:51]

dmurph@chromium.org changed reviewers:
+ holte@chromium.org, kinuko@chromium.org

[dmurph, 2016-05-17 18:43:52]

+holte for histogram changes
+kinuko for WebKit/Source changes (please let me know if I should pick someone
else)

[dmurph, 2016-05-17 18:46:15]

dmurph@chromium.org changed reviewers:
+ chrishtr@chromium.org
- kinuko@chromium.org

[dmurph, 2016-05-17 18:46:15]

-kinuko, +chrishtr

[chrishtr, 2016-05-17 18:53:15]

lgtm

[Steven Holte, 2016-05-17 19:17:28]

histograms lgtm

[dmurph, 2016-05-17 20:03:36]

The CQ bit was checked by dmurph@chromium.org

[commit-bot: I haz the power, 2016-05-17 20:04:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987563002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987563002/1

[commit-bot: I haz the power, 2016-05-17 20:08:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 20:08:40]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dmurph, 2016-05-17 20:13:55]

The CQ bit was checked by dmurph@chromium.org

[dmurph, 2016-05-17 20:13:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, chasej@chromium.org, holte@chromium.org
Link to the patchset: https://codereview.chromium.org/1987563002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-17 20:14:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987563002/20001

[commit-bot: I haz the power, 2016-05-17 21:45:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 21:45:31]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmurph, 2016-05-18 04:19:21]

On 2016/05/17 at 21:45:31, commit-bot wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Chase, are you sure I'm supposed to remove 'RuntimeEnabled'? This causes the
storage manager to become visible in the layout tests above.

[dmurph, 2016-05-18 04:39:42]

I confirmed with Jason that I needed to change test expectations, as origin
trials have the item exposed, but instead of the real implementation it prints
out "CONSOLE ERROR: The 'DurableStorage' feature is currently enabled in limited
trials. Please see https://bit.ly/OriginTrials for information on enabling a
trial for your site.".

[dmurph, 2016-05-18 04:39:46]

The CQ bit was checked by dmurph@chromium.org

[dmurph, 2016-05-18 04:39:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, chasej@chromium.org, holte@chromium.org
Link to the patchset: https://codereview.chromium.org/1987563002/#ps40001
(title: "changed test expectations")

[commit-bot: I haz the power, 2016-05-18 04:39:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987563002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987563002/40001

[commit-bot: I haz the power, 2016-05-18 06:04:53]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-18 06:06:14]

Description was changed from

==========
[DurableStorage] Add UseCounter and fixed IDL

This adds use counters to the durable storage StorageManager javascript
API, and also switches the feature runtime flag to OriginTrialEnabled
instead of RuntimeEnabled.

BUG=610500
==========

to

==========
[DurableStorage] Add UseCounter and fixed IDL

This adds use counters to the durable storage StorageManager javascript
API, and also switches the feature runtime flag to OriginTrialEnabled
instead of RuntimeEnabled.

BUG=610500

Committed: https://crrev.com/90df253575a992dadeefd82e95069a24281cc1a1
Cr-Commit-Position: refs/heads/master@{#394339}
==========

[commit-bot: I haz the power, 2016-05-18 06:06:15]

Patchset 3 (id:??) landed as
https://crrev.com/90df253575a992dadeefd82e95069a24281cc1a1
Cr-Commit-Position: refs/heads/master@{#394339}