Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2426)

Unified Diff: content/renderer/devtools/devtools_agent_filter.h

Issue 198753002: Don't handle DispatchOnInspectorBackend msg for SharedWorkers in DevToolsAgentFilter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename OnUI to OnMainThread. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/devtools/devtools_agent_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/devtools/devtools_agent_filter.h
diff --git a/content/renderer/devtools/devtools_agent_filter.h b/content/renderer/devtools/devtools_agent_filter.h
index e7f78613807bcccb8f50885661dbf2a1e8acf3b9..8935833e4b201dbab672de4065044e1da5d7b62c 100644
--- a/content/renderer/devtools/devtools_agent_filter.h
+++ b/content/renderer/devtools/devtools_agent_filter.h
@@ -5,6 +5,7 @@
#ifndef CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_AGENT_FILTER_H_
#define CONTENT_RENDERER_DEVTOOLS_DEVTOOLS_AGENT_FILTER_H_
+#include <set>
#include <string>
#include "ipc/ipc_channel_proxy.h"
@@ -33,16 +34,28 @@ class DevToolsAgentFilter : public IPC::ChannelProxy::MessageFilter {
// IPC::ChannelProxy::MessageFilter override. Called on IO thread.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+ // Called on the main thread.
+ void AddSharedWorkerRouteOnMainThread(int32 routing_id);
+ void RemoveSharedWorkerRouteOnMainThread(int32 routing_id);
+
protected:
virtual ~DevToolsAgentFilter();
private:
void OnDispatchOnInspectorBackend(const std::string& message);
+ // Called on IO thread
+ void AddSharedWorkerRoute(int32 routing_id);
+ void RemoveSharedWorkerRoute(int32 routing_id);
+
bool message_handled_;
base::MessageLoop* render_thread_loop_;
+ // Proxy to the IO message loop.
+ scoped_refptr<base::MessageLoopProxy> io_message_loop_proxy_;
int current_routing_id_;
+ std::set<int32> shared_worker_routes_;
+
DISALLOW_COPY_AND_ASSIGN(DevToolsAgentFilter);
};
« no previous file with comments | « no previous file | content/renderer/devtools/devtools_agent_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698