Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 1987443002: MD Settings: convert some bluetooth i18n-content to $i18n{} (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: convert some bluetooth i18n-content to $i18n{} Based on https://codereview.chromium.org/1970923002/ by Dave Schuyler <dschuyler@chromium.org>; R=dschuyler@chromium.org BUG=611188 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/6f6c70d4f1281f3b29f425f2b680c5236dfe91ea Cr-Commit-Position: refs/heads/master@{#394292}

Patch Set 1 #

Patch Set 2 : wrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html View 1 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Dan Beam
4 years, 7 months ago (2016-05-16 20:51:09 UTC) #3
Dan Beam
ping
4 years, 7 months ago (2016-05-17 21:27:44 UTC) #4
dschuyler
lgtm
4 years, 7 months ago (2016-05-17 23:53:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987443002/20001
4 years, 7 months ago (2016-05-17 23:56:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 00:38:26 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 00:40:42 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f6c70d4f1281f3b29f425f2b680c5236dfe91ea
Cr-Commit-Position: refs/heads/master@{#394292}

Powered by Google App Engine
This is Rietveld 408576698