Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 198743002: Make the event-handler handle backpreasure. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make the event-handler handle backpreasure. We now limit the number of active events per fd to 8. BUG= R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=33649

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix for mac #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : Doc fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -237 lines) Patch
M runtime/bin/eventhandler.h View 3 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/eventhandler_android.h View 1 2 3 4 chunks +19 lines, -17 lines 0 comments Download
M runtime/bin/eventhandler_android.cc View 1 2 3 4 9 chunks +46 lines, -70 lines 0 comments Download
M runtime/bin/eventhandler_linux.h View 1 2 3 1 chunk +65 lines, -4 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 1 2 3 4 7 chunks +195 lines, -82 lines 0 comments Download
M runtime/bin/eventhandler_macos.h View 1 2 5 chunks +17 lines, -13 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 1 2 9 chunks +27 lines, -36 lines 0 comments Download
M runtime/bin/eventhandler_win.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/eventhandler_win.cc View 1 2 3 3 chunks +4 lines, -6 lines 0 comments Download
M runtime/bin/socket_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 2 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Anders Johnsen
Note that this is mostly a revert of some of the latest changes, with the ...
6 years, 9 months ago (2014-03-13 09:41:18 UTC) #1
Anders Johnsen
6 years, 9 months ago (2014-03-13 09:42:21 UTC) #2
Bill Hesse
LGTM. https://codereview.chromium.org/198743002/diff/60001/runtime/bin/eventhandler_android.cc File runtime/bin/eventhandler_android.cc (left): https://codereview.chromium.org/198743002/diff/60001/runtime/bin/eventhandler_android.cc#oldcode175 runtime/bin/eventhandler_android.cc:175: AddToEpollInstance(epoll_fd_, sd); I assume there is no case ...
6 years, 9 months ago (2014-03-13 11:48:01 UTC) #3
Anders Johnsen
https://codereview.chromium.org/198743002/diff/60001/runtime/bin/eventhandler_android.cc File runtime/bin/eventhandler_android.cc (left): https://codereview.chromium.org/198743002/diff/60001/runtime/bin/eventhandler_android.cc#oldcode175 runtime/bin/eventhandler_android.cc:175: AddToEpollInstance(epoll_fd_, sd); On 2014/03/13 11:48:02, Bill Hesse wrote: > ...
6 years, 9 months ago (2014-03-13 12:02:21 UTC) #4
Anders Johnsen
Committed patchset #5 manually as r33649 (presubmit successful).
6 years, 9 months ago (2014-03-13 12:03:07 UTC) #5
Søren Gjesse
6 years, 9 months ago (2014-03-14 08:23:12 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698