[Android] Expose foreign session sync related funtionalities through JNI.

chrome/browser/android/foreign_session_helper.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_FOREIGN_SESSION_HELPER_H_
+#define CHROME_BROWSER_ANDROID_FOREIGN_SESSION_HELPER_H_
+
+#include <jni.h>
+
+#include "base/android/scoped_java_ref.h"
+#include "base/basictypes.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/webui/session_favicon_source.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+
+using base::android::ScopedJavaLocalRef;
+
+class SessionWindow;
+
+namespace browser_sync {
+class SessionModelAssociator;
+class SyncedSession;
+}  // namespace browser_sync
+
+class ForeignSessionHelper : public content::NotificationObserver {
+ public:
+  static bool RegisterForeignSessionHelper(JNIEnv* env);

[Ted C, 2013/07/26 22:29:47]

the ordering of the methods should be as close as possible in the header and the
cc file.  So I would move this to the bottom of the public section and adjust a
bit.

[Kibeom Kim (inactive), 2013/07/26 23:32:52]

Done.

+
+  explicit ForeignSessionHelper(Profile* profile);
+  void Destroy(JNIEnv* env, jobject obj);
+  jboolean IsTabSyncEnabled(JNIEnv* env, jobject obj);
+  void SetOnForeignSessionCallback(JNIEnv* env, jobject obj, jobject callback);
+  virtual void Observe(int type, const content::NotificationSource& source,

[Ted C, 2013/07/26 22:29:47]

I usually see all the overridden methods separated from the one's your adding to
make it easier to see.

Sometimes, there will be a comment like "// NotificationObserver implemenation"
before them.

[Ted C, 2013/07/26 22:29:47]

if all the params don't fit on one line, then each one gets it's own.

[Kibeom Kim (inactive), 2013/07/26 23:32:52]

Done.

[Kibeom Kim (inactive), 2013/07/26 23:32:52]

Done.

+                       const content::NotificationDetails& details) OVERRIDE;
+  jboolean GetForeignSessions(JNIEnv* env, jobject obj, jobject result);
+  jboolean OpenForeignSessionTab(JNIEnv* env, jobject obj, jstring session_tag,
+                                 jint tab_id);
+  void SetForeignSessionCollapsed(JNIEnv* env, jobject obj, jstring session_tag,
+                                  jboolean is_collapsed);
+  void DeleteForeignSession(JNIEnv* env, jobject obj, jstring session_tag);
+
+ private:
+  Profile* profile_;  // weak
+  base::android::ScopedJavaGlobalRef<jobject> callback_;
+  content::NotificationRegistrar registrar_;
+  browser_sync::SessionModelAssociator* GetSessionModelAssociator();

[Ted C, 2013/07/26 22:29:47]

private methods above variables.

[Kibeom Kim (inactive), 2013/07/26 23:32:52]

Done.

+
+  void CopyTabsToJava(JNIEnv* env, const SessionWindow* window,
+                      ScopedJavaLocalRef<jobject>& j_window);
+  void CopyWindowsToJava(JNIEnv* env,
+                         const browser_sync::SyncedSession* session,
+                         ScopedJavaLocalRef<jobject>& j_session);
+  virtual ~ForeignSessionHelper() {}

[Kibeom Kim (inactive), 2013/07/26 18:35:44]

clang build complains having {} here. I'll move {} to .cc in the next patchset.

[Kibeom Kim (inactive), 2013/07/26 23:32:52]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(ForeignSessionHelper);
+};
+
+#endif  // CHROME_BROWSER_ANDROID_FOREIGN_SESSION_HELPER_H_