Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1987393003: Fix ServiceWorkerPushMessagingTest.OnPush. (Closed)

Created:
4 years, 7 months ago by lazyboy
Modified:
4 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ServiceWorkerPushMessagingTest.OnPush. r394194 exposed some race. It seems that waiting for a push message to be handled by push_service() is the right thing to do. BUG=612840, 612673 Test=On Chromeos and windows, the test now always pass locally. Committed: https://crrev.com/d429e25851e808a426a8a692525987f3da008559 Cr-Commit-Position: refs/heads/master@{#395153}

Patch Set 1 #

Patch Set 2 : enable test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M chrome/browser/extensions/service_worker_apitest.cc View 1 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
lazyboy
4 years, 7 months ago (2016-05-18 22:52:22 UTC) #2
Devlin
lgtm
4 years, 7 months ago (2016-05-20 17:30:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987393003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987393003/20001
4 years, 7 months ago (2016-05-20 20:13:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 20:19:09 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 20:20:55 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d429e25851e808a426a8a692525987f3da008559
Cr-Commit-Position: refs/heads/master@{#395153}

Powered by Google App Engine
This is Rietveld 408576698