Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1987373003: Implement setPoster for WMPI (Closed)

Created:
4 years, 7 months ago by hubbe
Modified:
4 years, 7 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement setPoster for WMPI BUG=606800 Committed: https://crrev.com/e4027f9fa3bd2cd8ea3ab1c0fa88a20e357d0bcc Cr-Commit-Position: refs/heads/master@{#394684}

Patch Set 1 #

Patch Set 2 : make it compile, maybe #

Patch Set 3 : declare WebURL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M media/blink/webmediaplayer_cast_android.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_cast_android.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
hubbe
4 years, 7 months ago (2016-05-18 22:51:13 UTC) #2
DaleCurtis
lgtm
4 years, 7 months ago (2016-05-18 22:52:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987373003/40001
4 years, 7 months ago (2016-05-18 22:57:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/224552)
4 years, 7 months ago (2016-05-19 04:02:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987373003/40001
4 years, 7 months ago (2016-05-19 04:17:41 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-19 05:18:23 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 05:19:55 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e4027f9fa3bd2cd8ea3ab1c0fa88a20e357d0bcc
Cr-Commit-Position: refs/heads/master@{#394684}

Powered by Google App Engine
This is Rietveld 408576698