Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1987363004: Build libraries for a number of services. (Closed)

Created:
4 years, 7 months ago by nellyv
Modified:
4 years, 7 months ago
Reviewers:
nelly, viettrungluu, qsr, ppi
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Build libraries for a number of services. Build libraries additionally to mojo applications for the following services: - services/files - services/icu_data - services/tracing - services/ui/input_manager - services/ui/launcher R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/88686a82ed8f1037bba3deacdd679fb8e717f2f6

Patch Set 1 #

Patch Set 2 : Fix intput_manager_service.mojo #

Total comments: 2

Patch Set 3 : remove unnecessary imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -90 lines) Patch
M services/files/BUILD.gn View 1 chunk +13 lines, -1 line 0 comments Download
A services/files/files_app.h View 1 chunk +31 lines, -0 lines 0 comments Download
A services/files/files_app.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M services/files/main.cc View 1 chunk +1 line, -31 lines 0 comments Download
M services/icu_data/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
A services/icu_data/icu_data_impl.h View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M services/icu_data/icu_data_impl.cc View 1 2 1 chunk +38 lines, -54 lines 0 comments Download
A + services/icu_data/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/tracing/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
M services/ui/input_manager/BUILD.gn View 1 2 chunks +11 lines, -1 line 0 comments Download
M services/ui/launcher/BUILD.gn View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
nelly
Hi Przemek and Ben, Ptal.
4 years, 7 months ago (2016-05-19 14:52:09 UTC) #2
nelly
4 years, 7 months ago (2016-05-19 15:29:02 UTC) #3
ppi
lgtm https://codereview.chromium.org/1987363004/diff/20001/services/icu_data/icu_data_impl.cc File services/icu_data/icu_data_impl.cc (right): https://codereview.chromium.org/1987363004/diff/20001/services/icu_data/icu_data_impl.cc#newcode13 services/icu_data/icu_data_impl.cc:13: #include "services/icu_data/kICUData.h" nit: no need to repeat the ...
4 years, 7 months ago (2016-05-19 15:58:37 UTC) #4
nelly
https://codereview.chromium.org/1987363004/diff/20001/services/icu_data/icu_data_impl.cc File services/icu_data/icu_data_impl.cc (right): https://codereview.chromium.org/1987363004/diff/20001/services/icu_data/icu_data_impl.cc#newcode13 services/icu_data/icu_data_impl.cc:13: #include "services/icu_data/kICUData.h" On 2016/05/19 15:58:37, ppi wrote: > nit: ...
4 years, 7 months ago (2016-05-19 16:09:52 UTC) #5
nellyv
Committed patchset #3 (id:40001) manually as 88686a82ed8f1037bba3deacdd679fb8e717f2f6 (presubmit successful).
4 years, 7 months ago (2016-05-19 16:17:49 UTC) #7
viettrungluu
4 years, 7 months ago (2016-05-19 16:52:42 UTC) #9
Message was sent while issue was closed. 
Seems bad that the CL description gives no indication for the reason for the
added complexity. Nor are there any comments in the BUILD.gn files indicating
the reason for the extra libraries.

Powered by Google App Engine
This is Rietveld 408576698