test/cctest/test-api.cc - Issue 1987363002: Revert of [heap] Do not invoke GC to make heap iterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 1987363002: Revert of [heap] Do not invoke GC to make heap iterable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index b97dd7706edd01489786aab51ce7e14c58ca3db3..647ff3214a2a73a181df5b572abfffac66f2139b 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -13912,7 +13912,7 @@

// been marked at that point. Therefore some of the maps are not

// collected until the second garbage collection.

CcTest::heap()->CollectAllGarbage();

- CcTest::heap()->CollectAllGarbage();

+ CcTest::heap()->CollectAllGarbage(i::Heap::kMakeHeapIterableMask);

int count = GetGlobalObjectsCount();

#ifdef DEBUG

if (count != expected) CcTest::heap()->TracePathToGlobal();

« no previous file with comments | « src/profiler/heap-snapshot-generator.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »