Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: components/ntp_snippets.gypi

Issue 1987333003: [NTP Snippets] Persist snippets in a LevelDB instead of prefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets.gypi
diff --git a/components/ntp_snippets.gypi b/components/ntp_snippets.gypi
index 215b2ce305b2c869fb9cc7f6752bcc5cddaa0585..6a0e06e71061772e658acf9480b166b9fecabe61 100644
--- a/components/ntp_snippets.gypi
+++ b/components/ntp_snippets.gypi
@@ -20,6 +20,7 @@
'data_use_measurement_core',
'image_fetcher',
'keyed_service_core',
+ 'leveldb_proto',
'prefs/prefs.gyp:prefs',
'signin_core_browser',
'suggestions',
@@ -31,6 +32,8 @@
'ntp_snippets/ntp_snippet.h',
'ntp_snippets/ntp_snippets_constants.cc',
'ntp_snippets/ntp_snippets_constants.h',
+ 'ntp_snippets/ntp_snippets_database.cc',
+ 'ntp_snippets/ntp_snippets_database.h',
'ntp_snippets/ntp_snippets_fetcher.cc',
'ntp_snippets/ntp_snippets_fetcher.h',
'ntp_snippets/ntp_snippets_scheduler.h',
@@ -38,9 +41,15 @@
'ntp_snippets/ntp_snippets_service.h',
'ntp_snippets/pref_names.cc',
'ntp_snippets/pref_names.h',
+ 'ntp_snippets/proto/ntp_snippets.proto',
'ntp_snippets/switches.cc',
'ntp_snippets/switches.h',
],
+ 'variables': {
+ 'proto_in_dir': 'ntp_snippets/proto',
+ 'proto_out_dir': 'components/ntp_snippets/proto',
+ },
+ 'includes': [ '../build/protoc.gypi' ],
Bernhard Bauer 2016/05/25 15:01:15 This just goes into the target for the static libr
Marc Treib 2016/05/27 14:03:12 Err.. what?
Bernhard Bauer 2016/05/27 16:06:42 This is part of the declaration of the target "ntp
Marc Treib 2016/05/30 13:22:00 Ah :) components/suggestions.gypi uses it in the s
},
],
}

Powered by Google App Engine
This is Rietveld 408576698