Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1987313004: Make official Blimp Engine builds have a symbol level of 0 (Closed)

Created:
4 years, 7 months ago by marcinjb
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, maniscalco
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make official Blimp Engine builds have a symbol level of 0 Using the 'is_official_build' gn flag pulls in a bunch of debugging symbols that we don't need for the engine, and in fact will bloat the binary size. Using a symbol level of 0 has no effect on the breakpad symbol file generated by dump_app_syms.py, so we don't lose any of our desired debugging capabilities. Tested by building with the buildbot configuration, uploading symbols, and causing an engine crash with 'kill -6'. BUG=613186 Committed: https://crrev.com/379f3f501b387fae1d2807b096f993015dbb3d68 Cr-Commit-Position: refs/heads/master@{#394906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/args/bots/official.desktop/blimp-engine.gn View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
marcinjb
4 years, 7 months ago (2016-05-19 21:29:32 UTC) #3
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-19 21:43:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987313004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987313004/1
4 years, 7 months ago (2016-05-19 23:32:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 23:37:56 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 23:40:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/379f3f501b387fae1d2807b096f993015dbb3d68
Cr-Commit-Position: refs/heads/master@{#394906}

Powered by Google App Engine
This is Rietveld 408576698