Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1987263002: gn: Add some missing tests to components_unittests. (Closed)

Created:
4 years, 7 months ago by Nico
Modified:
4 years, 7 months ago
Reviewers:
sdefresne, blundell
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Add some missing tests to components_unittests. (It looks like there are more tests missing in components_unittests, but I don't understand why the other missing tests are missing -- from looking at the .gn files they should be there, but they aren't.) BUG=604060 Committed: https://crrev.com/69c290c4783727c88f6e1a3a090f4b75554626ff Cr-Commit-Position: refs/heads/master@{#394414}

Patch Set 1 #

Patch Set 2 : err #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Nico
4 years, 7 months ago (2016-05-18 13:23:56 UTC) #2
blundell
Sylvain's a better reviewer.
4 years, 7 months ago (2016-05-18 13:25:14 UTC) #4
sdefresne
lgtm Which other tests?
4 years, 7 months ago (2016-05-18 14:05:49 UTC) #5
Nico
patch set 1 had one more, but that was already there in an !is_android block. ...
4 years, 7 months ago (2016-05-18 14:09:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987263002/20001
4 years, 7 months ago (2016-05-18 14:09:55 UTC) #8
blundell
On 2016/05/18 14:09:33, Nico (vacation May 19 to 22) wrote: > patch set 1 had ...
4 years, 7 months ago (2016-05-18 14:13:35 UTC) #9
sdefresne
Yes, this is what I meant :-)
4 years, 7 months ago (2016-05-18 14:16:50 UTC) #10
Nico
See the attachment at https://bugs.chromium.org/p/chromium/issues/detail?id=604060#c17 : components_unittests 497d496 < CallObserver 585d583 < CheckBookmarkDefined 593a592,593 > ...
4 years, 7 months ago (2016-05-18 14:25:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 14:30:54 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 14:32:04 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69c290c4783727c88f6e1a3a090f4b75554626ff
Cr-Commit-Position: refs/heads/master@{#394414}

Powered by Google App Engine
This is Rietveld 408576698