gn: Add some missing tests to components_unittests.

gn: Add some missing tests to components_unittests.

(It looks like there are more tests missing in components_unittests, but I
don't understand why the other missing tests are missing -- from looking at
the .gn files they should be there, but they aren't.)

BUG=604060
Committed: https://crrev.com/69c290c4783727c88f6e1a3a090f4b75554626ff
Cr-Commit-Position: refs/heads/master@{#394414}

[Nico, 2016-05-18 13:23:55]

thakis@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2016-05-18 13:25:13]

blundell@chromium.org changed reviewers:
+ sdefresne@chromium.org

[blundell, 2016-05-18 13:25:14]

Sylvain's a better reviewer.

[sdefresne, 2016-05-18 14:05:49]

lgtm

Which other tests?

[Nico, 2016-05-18 14:09:33]

patch set 1 had one more, but that was already there in an !is_android block.
But the missing target contains more than one cc file, so plural still isn't
completely wrong...

[Nico, 2016-05-18 14:09:42]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-05-18 14:09:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987263002/20001

[blundell, 2016-05-18 14:13:35]

On 2016/05/18 14:09:33, Nico (vacation May 19 to 22) wrote:
> patch set 1 had one more, but that was already there in an !is_android block.
> But the missing target contains more than one cc file, so plural still isn't
> completely wrong...

I think that Sylvain means which other tests are missing (from your CL
description).

[sdefresne, 2016-05-18 14:16:50]

Yes, this is what I meant :-)

[Nico, 2016-05-18 14:25:46]

See the attachment at
https://bugs.chromium.org/p/chromium/issues/detail?id=604060#c17 :


components_unittests
497d496
<   CallObserver
585d583
<   CheckBookmarkDefined
593a592,593
>   CheckDeclinedFalse
>   CheckDeclinedTrue
604d603
<   CheckLastNDefined
644a644
> ChildTraceMessageFilterTest.
698d697
< ClientPolicyControllerTest.
826a826
> ConstrainedWindowViewsTest.
946a947
> CrashKeysTest.
1111a1113
>   DecryptExampleReport
1130d1131
< DefaultSearchPolicyHandlerTest.
1355d1355
<   Disabled
1698a1699,1700
> ErrorReporterTest.
> ErrorReportTest.
1767a1770
>   ExtendedReportingSendReport
1835d1837
<   FallbackTest
1899d1900
<   FileURL
1959a1961
>   FilterFlags
2123d2124
<   FullyDefined
2439d2439
<   GetReadError
2451d2450
<   GetSetObserver
2526a2526
>   GrowModalDialogSize
2797d2796
<   Initialization
2841d2839
< InMemoryPrefStoreTest.
2877d2874
<   Invalid
3269a3267,3268
>   MaximumBrowserDialogSize
>   MaximumWebContentsDialogSize
3384d3382
<   MinimallyDefined
3388d3385
<   MissingUrl
3665d3661
< OfflinePageStorageManagerTest.
3950a3947
>   ParseSerializedReport
4370,4371d4366
<   ReadOnly
<   ReadPrefs
4939a4935,4936
>   SerializedReportAsProtobuf
>   SerializedReportAsProtobufWithInterstitialInfo
5020d5016
<   SetGetValue
5025a5022,5023
>   SetLanguageBlocked
>   SetLanguageBlockedIn2016Q2UI
5092a5091
>   ShouldAlwaysTranslateBeCheckedByDefault
5128a5128
>   ShrinkModalDialogSize
5432a5433
>   Switches
5547,5549d5547
<   TestClearPagesLessThanLimit
<   TestClearPagesMoreFreshPages
<   TestClearPagesMoreThanLimit
5659a5658,5660
>   TestHistogramAborts
>   TestHistogramDoesNotTrigger
>   TestHistogramTriggers
6025a6027
> TranslateUIDelegateTest.

[commit-bot: I haz the power, 2016-05-18 14:30:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-18 14:32:03]

Description was changed from

==========
gn: Add some missing tests to components_unittests.

(It looks like there are more tests missing in components_unittests, but I
don't understand why the other missing tests are missing -- from looking at
the .gn files they should be there, but they aren't.)

BUG=604060
==========

to

==========
gn: Add some missing tests to components_unittests.

(It looks like there are more tests missing in components_unittests, but I
don't understand why the other missing tests are missing -- from looking at
the .gn files they should be there, but they aren't.)

BUG=604060

Committed: https://crrev.com/69c290c4783727c88f6e1a3a090f4b75554626ff
Cr-Commit-Position: refs/heads/master@{#394414}
==========

[commit-bot: I haz the power, 2016-05-18 14:32:04]

Patchset 2 (id:??) landed as
https://crrev.com/69c290c4783727c88f6e1a3a090f4b75554626ff
Cr-Commit-Position: refs/heads/master@{#394414}