Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 198723005: Use the Document AnimationClock in SMILTimeContainer (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), gyuyoung.kim_webkit.org, darktears, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Use the Document AnimationClock in SMILTimeContainer It's trivial to replace the local AnimationClock in SMILTimeContainer with the one from Document after making the observation that the only current manipulations (updateTime/unfreeze) are already performed by PageAnimator (DocumentAnimations::updateAnimationTimingForAnimationFrame) and RenderLayerCompositor (DocumentAnimations::startPendingAnimations). With this change it become possible to push the DiscardScope into updateAnimationsAndScheduleFrameIfNeeded - so do that to simplify the code (by reducing the number of places that instantiate a DiscardScope.) BUG=231576 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169761

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -16 lines) Patch
M Source/core/svg/animation/SMILTimeContainer.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/svg/animation/SMILTimeContainer.cpp View 5 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fs
6 years, 9 months ago (2014-03-17 15:55:03 UTC) #1
fs
On 2014/03/17 15:55:03, fs wrote: Ping!
6 years, 9 months ago (2014-03-21 16:44:53 UTC) #2
pdr.
On 2014/03/21 16:44:53, fs wrote: > On 2014/03/17 15:55:03, fs wrote: > > Ping! LGTM ...
6 years, 9 months ago (2014-03-21 17:47:03 UTC) #3
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-21 17:47:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/198723005/20001
6 years, 9 months ago (2014-03-21 17:47:25 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 18:52:38 UTC) #6
Message was sent while issue was closed. 
Change committed as 169761

Powered by Google App Engine
This is Rietveld 408576698