Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1987213002: Clean up code and logic related to platform accessibility node destruction. (Closed)

Created:
4 years, 7 months ago by mharanczyk
Modified:
4 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up code and logic related to platform accessibility node destruction. Committed: https://crrev.com/fc4b14e1762e295009fa17e12ebcead02f6f6b23 Cr-Commit-Position: refs/heads/master@{#394733}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M ui/accessibility/platform/ax_platform_node_auralinux.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_auralinux.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_base.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_base.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 chunk +1 line, -2 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.h View 2 chunks +4 lines, -1 line 0 comments Download
M ui/accessibility/platform/ax_platform_node_win.cc View 1 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mharanczyk
dmazzoni@ here is a cleanup of platform accessibility nodes destruction logic. I've added Dispose method ...
4 years, 7 months ago (2016-05-18 10:31:02 UTC) #2
dmazzoni
lgtm Thanks, this is great.
4 years, 7 months ago (2016-05-18 16:34:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987213002/20001
4 years, 7 months ago (2016-05-19 09:58:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 11:06:48 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 11:07:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc4b14e1762e295009fa17e12ebcead02f6f6b23
Cr-Commit-Position: refs/heads/master@{#394733}

Powered by Google App Engine
This is Rietveld 408576698