Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1987193002:
WebFonts: show a console message when an intervention is triggered (Closed)
|
Created:
4 years, 7 months ago by Takashi Toyoshima Modified:
4 years, 7 months ago CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWebFonts: show a console message when an intervention is triggered
To be clear when and for what the intervention happens, let me show
a console message in DevTools. This will help to triage bug reports
from users for coming v2 implementation.
This change also fixes a bug that enable-webfonts-intervention-trigger
flag wasn't propageted from the browser to renderers.
BUG=607788, 578029
Committed: https://crrev.com/62cdfb92ab962c0c8678000b1265037209b33c65
Cr-Commit-Position: refs/heads/master@{#394674}
Patch Set 1 #Patch Set 2 : . #
Total comments: 3
Messages
Total messages: 21 (9 generated)
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987193002/20001
Description was changed from ========== WebFonts: show a console message when an intervention is triggered To be clear when and for what the intervention happens, let me show a console message in DevTools. This will help to triage bug reports from users for coming v2 implementation. BUG=n/a ========== to ========== WebFonts: show a console message when an intervention is triggered To be clear when and for what the intervention happens, let me show a console message in DevTools. This will help to triage bug reports from users for coming v2 implementation. BUG=n/a ==========
toyoshim@chromium.org changed reviewers: + kinuko@chromium.org, ksakamoto@chromium.org
Sakamoto-san, can you take a look? Kinuko-san is for OWNERS review that's needed after the Sakamoto-san's review.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
https://codereview.chromium.org/1987193002/diff/20001/content/browser/rendere... File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/1987193002/diff/20001/content/browser/rendere... content/browser/renderer_host/render_process_host_impl.cc:1422: switches::kEnableWebFontsInterventionTrigger, Is this necessary to show the console message?
https://codereview.chromium.org/1987193002/diff/20001/content/browser/rendere... File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/1987193002/diff/20001/content/browser/rendere... content/browser/renderer_host/render_process_host_impl.cc:1422: switches::kEnableWebFontsInterventionTrigger, Yes for manual testing. Actually, this was a bug that the flag wasn't propagated to renderers. I notice this by manual testing this implementation. Do you think it's better to split this?
lgtm https://codereview.chromium.org/1987193002/diff/20001/content/browser/rendere... File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/1987193002/diff/20001/content/browser/rendere... content/browser/renderer_host/render_process_host_impl.cc:1422: switches::kEnableWebFontsInterventionTrigger, On 2016/05/18 09:06:56, Takashi Toyoshima (still slow) wrote: > Yes for manual testing. > Actually, this was a bug that the flag wasn't propagated to renderers. I notice > this by manual testing this implementation. > > Do you think it's better to split this? I see. No need to split this, but please mention that in the CL description.
Description was changed from ========== WebFonts: show a console message when an intervention is triggered To be clear when and for what the intervention happens, let me show a console message in DevTools. This will help to triage bug reports from users for coming v2 implementation. BUG=n/a ========== to ========== WebFonts: show a console message when an intervention is triggered To be clear when and for what the intervention happens, let me show a console message in DevTools. This will help to triage bug reports from users for coming v2 implementation. This change also fixes a bug that enable-webfonts-intervention-trigger flag wasn't propageted from the browser to renderers. BUG=n/a ==========
Thanks. I updated the CL description.
lgtm (No associated BUG= ?)
Description was changed from ========== WebFonts: show a console message when an intervention is triggered To be clear when and for what the intervention happens, let me show a console message in DevTools. This will help to triage bug reports from users for coming v2 implementation. This change also fixes a bug that enable-webfonts-intervention-trigger flag wasn't propageted from the browser to renderers. BUG=n/a ========== to ========== WebFonts: show a console message when an intervention is triggered To be clear when and for what the intervention happens, let me show a console message in DevTools. This will help to triage bug reports from users for coming v2 implementation. This change also fixes a bug that enable-webfonts-intervention-trigger flag wasn't propageted from the browser to renderers. BUG=607788, 578029 ==========
ok, let me add two bugs, one is there we discuss having this console message, and the other is for the intervention v2.
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987193002/20001
Message was sent while issue was closed.
Description was changed from ========== WebFonts: show a console message when an intervention is triggered To be clear when and for what the intervention happens, let me show a console message in DevTools. This will help to triage bug reports from users for coming v2 implementation. This change also fixes a bug that enable-webfonts-intervention-trigger flag wasn't propageted from the browser to renderers. BUG=607788, 578029 ========== to ========== WebFonts: show a console message when an intervention is triggered To be clear when and for what the intervention happens, let me show a console message in DevTools. This will help to triage bug reports from users for coming v2 implementation. This change also fixes a bug that enable-webfonts-intervention-trigger flag wasn't propageted from the browser to renderers. BUG=607788, 578029 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== WebFonts: show a console message when an intervention is triggered To be clear when and for what the intervention happens, let me show a console message in DevTools. This will help to triage bug reports from users for coming v2 implementation. This change also fixes a bug that enable-webfonts-intervention-trigger flag wasn't propageted from the browser to renderers. BUG=607788, 578029 ========== to ========== WebFonts: show a console message when an intervention is triggered To be clear when and for what the intervention happens, let me show a console message in DevTools. This will help to triage bug reports from users for coming v2 implementation. This change also fixes a bug that enable-webfonts-intervention-trigger flag wasn't propageted from the browser to renderers. BUG=607788, 578029 Committed: https://crrev.com/62cdfb92ab962c0c8678000b1265037209b33c65 Cr-Commit-Position: refs/heads/master@{#394674} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/62cdfb92ab962c0c8678000b1265037209b33c65 Cr-Commit-Position: refs/heads/master@{#394674} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
