[stubs] Convert Internal/ArraySingleArgumentsConstructor to a TurboFan stub

[stubs] Convert Internal/ArraySingleArgumentsConstructor to a TurboFan stub

BUG=chromium:608675
LOG=n

Committed: https://crrev.com/02c8b6f7f0f8801f0cdc33bef576e3b0c3db394e
Cr-Commit-Position: refs/heads/master@{#36463}

[danno, 2016-05-20 11:08:27]

Description was changed from

==========
[stubs] Convert InternalArraySingleArgumentsConstructor to a TurboFan stub
==========

to

==========
[stubs] Convert Internal/ArraySingleArgumentsConstructor to a TurboFan stub

BUG=chromium:608675
LOG=n
==========

[danno, 2016-05-23 10:03:34]

danno@chromium.org changed reviewers:
+ bmeurer@chromium.org

[danno, 2016-05-23 10:03:36]

PTAL

[Benedikt Meurer, 2016-05-24 04:36:21]

LGTM with nits.

https://codereview.chromium.org/1987183002/diff/350001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1987183002/diff/350001/src/code-stubs.cc#newc...
src/code-stubs.cc:4514: static void SingleArgumentConstructorCommon(
Nit: static is unnecessary within anonymous namespace

https://codereview.chromium.org/1987183002/diff/350001/src/code-stubs.cc#newc...
src/code-stubs.cc:4521: CodeStubAssembler::Label ok(assembler);
You don't need CodeStubAssembler:: since you typedef'd above.

[danno, 2016-05-24 07:39:22]

The CQ bit was checked by danno@chromium.org

[danno, 2016-05-24 07:39:22]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1987183002/#ps370001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-05-24 07:39:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1987183002/370001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1987183002/370001

[danno, 2016-05-24 07:39:32]

Feedback addressed, landing

https://codereview.chromium.org/1987183002/diff/350001/src/code-stubs.cc
File src/code-stubs.cc (right):

https://codereview.chromium.org/1987183002/diff/350001/src/code-stubs.cc#newc...
src/code-stubs.cc:4514: static void SingleArgumentConstructorCommon(
On 2016/05/24 04:36:21, Benedikt Meurer wrote:
> Nit: static is unnecessary within anonymous namespace

Done.

https://codereview.chromium.org/1987183002/diff/350001/src/code-stubs.cc#newc...
src/code-stubs.cc:4521: CodeStubAssembler::Label ok(assembler);
On 2016/05/24 04:36:21, Benedikt Meurer wrote:
> You don't need CodeStubAssembler:: since you typedef'd above.

Done.

[commit-bot: I haz the power, 2016-05-24 08:14:53]

Description was changed from

==========
[stubs] Convert Internal/ArraySingleArgumentsConstructor to a TurboFan stub

BUG=chromium:608675
LOG=n
==========

to

==========
[stubs] Convert Internal/ArraySingleArgumentsConstructor to a TurboFan stub

BUG=chromium:608675
LOG=n
==========

[commit-bot: I haz the power, 2016-05-24 08:14:55]

Committed patchset #20 (id:370001)

[commit-bot: I haz the power, 2016-05-24 08:16:24]

Description was changed from

==========
[stubs] Convert Internal/ArraySingleArgumentsConstructor to a TurboFan stub

BUG=chromium:608675
LOG=n
==========

to

==========
[stubs] Convert Internal/ArraySingleArgumentsConstructor to a TurboFan stub

BUG=chromium:608675
LOG=n

Committed: https://crrev.com/02c8b6f7f0f8801f0cdc33bef576e3b0c3db394e
Cr-Commit-Position: refs/heads/master@{#36463}
==========

[commit-bot: I haz the power, 2016-05-24 08:16:25]

Patchset 20 (id:??) landed as
https://crrev.com/02c8b6f7f0f8801f0cdc33bef576e3b0c3db394e
Cr-Commit-Position: refs/heads/master@{#36463}