Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: remoting/protocol/jingle_session.cc

Issue 1987163002: Add DOMAIN_MISMATCH message end to end (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO in Jingle session Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/jingle_messages.cc ('k') | remoting/protocol/me2me_host_authenticator_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/jingle_session.cc
diff --git a/remoting/protocol/jingle_session.cc b/remoting/protocol/jingle_session.cc
index ba523000e7cf9fcf1320d295dec8f71e0dc44e3f..1f266ac04fda4f69bd57c0ce89b95c28e0c8170d 100644
--- a/remoting/protocol/jingle_session.cc
+++ b/remoting/protocol/jingle_session.cc
@@ -54,6 +54,8 @@ ErrorCode AuthRejectionReasonToErrorCode(
return AUTHENTICATION_FAILED;
case Authenticator::PROTOCOL_ERROR:
return INCOMPATIBLE_PROTOCOL;
+ case Authenticator::INVALID_ACCOUNT:
+ return INVALID_ACCOUNT;
}
NOTREACHED();
return UNKNOWN_ERROR;
@@ -245,6 +247,11 @@ void JingleSession::Close(protocol::ErrorCode error) {
case AUTHENTICATION_FAILED:
reason = JingleMessage::DECLINE;
break;
+ case INVALID_ACCOUNT:
+ // TODO(zijiehe): Instead of using SECURITY_ERROR Jingle reason, add a
+ // new tag under crd namespace to export detail error reason to client.
+ reason = JingleMessage::SECURITY_ERROR;
+ break;
case INCOMPATIBLE_PROTOCOL:
reason = JingleMessage::INCOMPATIBLE_PARAMETERS;
break;
@@ -484,6 +491,9 @@ void JingleSession::OnTerminate(const JingleMessage& message,
case JingleMessage::DECLINE:
error_ = AUTHENTICATION_FAILED;
break;
+ case JingleMessage::SECURITY_ERROR:
+ error_ = INVALID_ACCOUNT;
+ break;
case JingleMessage::CANCEL:
error_ = HOST_OVERLOAD;
break;
« no previous file with comments | « remoting/protocol/jingle_messages.cc ('k') | remoting/protocol/me2me_host_authenticator_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698