Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 198713002: move remaining uses of scanner literals into scanner (Closed)

Created:
6 years, 9 months ago by dcarney
Modified:
6 years, 9 months ago
Reviewers:
marja
CC:
v8-dev
Visibility:
Public.

Description

move remaining uses of scanner literals into scanner R=marja@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19880

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -88 lines) Patch
M src/preparser.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/preparser.cc View 1 2 chunks +2 lines, -14 lines 0 comments Download
M src/scanner.h View 1 6 chunks +63 lines, -56 lines 0 comments Download
M src/scanner.cc View 1 3 chunks +23 lines, -12 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
marja
lgtm
6 years, 9 months ago (2014-03-13 08:19:58 UTC) #1
dcarney
6 years, 9 months ago (2014-03-13 08:29:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 manually as r19880 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698