cc : Track transform animation changes on transform tree

cc/animation/element_animations.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_ANIMATION_ELEMENT_ANIMATIONS_H_
 #define CC_ANIMATION_ELEMENT_ANIMATIONS_H_
 
 #include <bitset>
 #include <memory>
 #include <vector>
@@ skipping 206 matching lines @@
                                      bool notify_pending_elements);
   void NotifyClientFilterAnimated(const FilterOperations& filter,
                                   bool notify_active_elements,
                                   bool notify_pending_elements);
   void NotifyClientScrollOffsetAnimated(const gfx::ScrollOffset& scroll_offset,
                                         bool notify_active_elements,
                                         bool notify_pending_elements);
 
   void NotifyClientAnimationWaitingForDeletion();
 
-  void NotifyClientTransformIsPotentiallyAnimatingChanged(
-      bool notify_active_elements,
-      bool notify_pending_elements);
+  void NotifyClientAnimationChanged(
+      TargetProperty::Type property,
+      ElementListType list_type,
+      bool notify_elements_about_potential_animation,
+      bool notify_elements_about_running_animation);
 
-  void UpdatePotentiallyAnimatingTransform();
-
-  void NotifyClientOpacityAnimationChanged(
-      bool notify_active_elements_about_potential_animation,
-      bool notify_active_elements_about_running_animation,
-      bool notify_pending_elements_about_potential_aniamtion,
-      bool notify_pending_elements_about_running_animation);
-
-  void UpdateAnimatingOpacity();
+  void UpdateAnimationState(TargetProperty::Type property);

[ajuma, 2016/05/18 17:09:12]

This name is confusingly close to the existing UpdateState method. Maybe call it
UpdateClientAnimationState or UpdateAnimatingProperties?

[jaydasika, 2016/05/18 21:42:37]

Done.

 
   void OnFilterAnimated(ElementListType list_type,
                         const FilterOperations& filters);
   void OnOpacityAnimated(ElementListType list_type, float opacity);
   void OnTransformAnimated(ElementListType list_type,
                            const gfx::Transform& transform);
   void OnScrollOffsetAnimated(ElementListType list_type,
                               const gfx::ScrollOffset& scroll_offset);
   void OnAnimationWaitingForDeletion();
-  void OnTransformIsPotentiallyAnimatingChanged(ElementListType list_type,
-                                                bool is_animating);
-  void OnOpacityIsAnimatingChanged(ElementListType list_type,
-                                   AnimationChangeType change_type,
-                                   bool is_animating);
+  void IsAnimatingChanged(ElementListType list_type,
+                          TargetProperty::Type property,
+                          AnimationChangeType change_type,
+                          bool is_animating);
   gfx::ScrollOffset ScrollOffsetForAnimation() const;
 
   void NotifyPlayersAnimationStarted(base::TimeTicks monotonic_time,
                                      TargetProperty::Type target_property,
                                      int group);
   void NotifyPlayersAnimationFinished(base::TimeTicks monotonic_time,
                                       TargetProperty::Type target_property,
                                       int group);
   void NotifyPlayersAnimationAborted(base::TimeTicks monotonic_time,
                                      TargetProperty::Type target_property,
@@ skipping 16 matching lines @@
 
   bool has_element_in_active_list_;
   bool has_element_in_pending_list_;
 
   // Only try to start animations when new animations are added or when the
   // previous attempt at starting animations failed to start all animations.
   bool needs_to_start_animations_;
 
   bool scroll_offset_animation_was_interrupted_;
 
+  bool currently_running_transform_animation_for_active_elements_;
+  bool currently_running_transform_animation_for_pending_elements_;
   bool potentially_animating_transform_for_active_elements_;
   bool potentially_animating_transform_for_pending_elements_;
 
   bool currently_running_opacity_animation_for_active_elements_;
   bool currently_running_opacity_animation_for_pending_elements_;
   bool potentially_animating_opacity_for_active_elements_;
   bool potentially_animating_opacity_for_pending_elements_;

[ajuma, 2016/05/18 17:09:12]

Wdyt of creating a struct for this 4-tuple, and then using instances of that
struct for opacity and transform? That might simplify some code, and will also
make it easier to add more target types (e.g. filter animations will need this
too once filters are owned by effect nodes).

[jaydasika, 2016/05/18 21:42:37]

Done.

 
   DISALLOW_COPY_AND_ASSIGN(ElementAnimations);
 };
 
 }  // namespace cc
 
 #endif  // CC_ANIMATION_ELEMENT_ANIMATIONS_H_