Issue 19871002: roll clang 184830:186332

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19871002: roll clang 184830:186332 (Closed)

Created:
7 years, 5 months ago by Nico

Modified:
7 years, 5 months ago

Reviewers:
Mark Mentovai, hans

CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org, Ami GONE FROM CHROMIUM

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

roll clang 184830:186332 * more precise -Wlogical-not-parentheses * fixes codegen issue encountered by webrtc BUG=262248 R=hans@chromium.org, mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212975

Patch Set 1 #

Patch Set 2 : try #

Patch Set 3 : trymore #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : foo #

Patch Set 7 : clang #

Patch Set 8 : rebase #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	base/process/memory_unittest.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/clang/scripts/update.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

mark: base/OWNERS please (without the 3 -> 9 change, clang optimizes away the test – ...

7 years, 5 months ago (2013-07-22 20:56:31 UTC) #1

Nico

7 years, 5 months ago (2013-07-22 21:46:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #8 manually as r212975 (presubmit successful).

Expand Messages | Collapse Messages