Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1987073003:
include translate_ui_delegate_unittest to gn build (Closed)
|
Created:
4 years, 7 months ago by ftang Modified:
4 years, 7 months ago Reviewers:
groby-ooo-7-16 CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptioninclude translate_ui_delegate_unittest to gn build
BUG=
Committed: https://crrev.com/ccca3fc2b211e33e1390675661fc0c20509be13e
Cr-Commit-Position: refs/heads/master@{#394629}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 16 (7 generated)
The CQ bit was checked by ftang@chromium.org to run a CQ dry run
Description was changed from ========== include translate_ui_delegate_unittest to gn build BUG= ========== to ========== include translate_ui_delegate_unittest to gn build BUG= ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987073003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ftang@chromium.org changed reviewers: + groby@chromium.org
https://codereview.chromium.org/1987073003/diff/1/components/translate/core/b... File components/translate/core/browser/BUILD.gn (left): https://codereview.chromium.org/1987073003/diff/1/components/translate/core/b... components/translate/core/browser/BUILD.gn:96: if (!use_aura) { I'm confused why this would need to be tested on non-bubble builds? I'm fine with it, but are we sure this makes sense?
On 2016/05/18 23:01:58, groby wrote: > https://codereview.chromium.org/1987073003/diff/1/components/translate/core/b... > File components/translate/core/browser/BUILD.gn (left): > > https://codereview.chromium.org/1987073003/diff/1/components/translate/core/b... > components/translate/core/browser/BUILD.gn:96: if (!use_aura) { > I'm confused why this would need to be tested on non-bubble builds? I'm fine > with it, but are we sure this makes sense? The translate_ui_delegate is not tight to bubble, right?
On 2016/05/18 23:51:29, ftang wrote: > On 2016/05/18 23:01:58, groby wrote: > > > https://codereview.chromium.org/1987073003/diff/1/components/translate/core/b... > > File components/translate/core/browser/BUILD.gn (left): > > > > > https://codereview.chromium.org/1987073003/diff/1/components/translate/core/b... > > components/translate/core/browser/BUILD.gn:96: if (!use_aura) { > > I'm confused why this would need to be tested on non-bubble builds? I'm fine > > with it, but are we sure this makes sense? > The translate_ui_delegate is not tight to bubble, right? You're right, I misread that. (I was only looking for dynamic allocation. The infobar has static allocation for its instance) LGTM
The CQ bit was checked by groby@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987073003/1
Message was sent while issue was closed.
Description was changed from ========== include translate_ui_delegate_unittest to gn build BUG= ========== to ========== include translate_ui_delegate_unittest to gn build BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== include translate_ui_delegate_unittest to gn build BUG= ========== to ========== include translate_ui_delegate_unittest to gn build BUG= Committed: https://crrev.com/ccca3fc2b211e33e1390675661fc0c20509be13e Cr-Commit-Position: refs/heads/master@{#394629} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ccca3fc2b211e33e1390675661fc0c20509be13e Cr-Commit-Position: refs/heads/master@{#394629} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
