Strip unused functionality from dart:html and fix strong mode errors. Switch from blacklisting pure…

Strip unused functionality from dart:html and fix strong mode errors. Switch from blacklisting pure interfaces to determining pure interfaces from the idl and whitelisting impure interfaces we need for dart2js.

BUG=
R=alanknight@google.com

Committed: https://github.com/dart-lang/sdk/commit/f26e522f84c5226beb0c57607571efe85a763e46

[Jacob, 2016-05-18 00:09:19]

jacobr@google.com changed reviewers:
+ vsm@google.com

[Jacob, 2016-05-18 00:09:20]

Shrink the diff for ddc specific dart:html significantly.

[Jacob, 2016-05-18 16:43:47]

jacobr@google.com changed reviewers:
+ alanknight@google.com

[Alan Knight, 2016-05-18 17:17:04]

lgtm

https://codereview.chromium.org/1987073002/diff/1/sdk/lib/html/dart2js/html_d...
File sdk/lib/html/dart2js/html_dart2js.dart (left):

https://codereview.chromium.org/1987073002/diff/1/sdk/lib/html/dart2js/html_d...
sdk/lib/html/dart2js/html_dart2js.dart:11648: -  String __getter__(int index);
Are these used by anything?  If they are, this seems odd. IDL says this is
non-spec and just converts the int to a string.

[Jacob, 2016-05-18 17:59:59]

https://codereview.chromium.org/1987073002/diff/1/sdk/lib/html/dart2js/html_d...
File sdk/lib/html/dart2js/html_dart2js.dart (left):

https://codereview.chromium.org/1987073002/diff/1/sdk/lib/html/dart2js/html_d...
sdk/lib/html/dart2js/html_dart2js.dart:11648: -  String __getter__(int index);
On 2016/05/18 17:17:04, Alan Knight wrote:
> Are these used by anything?  If they are, this seems odd. IDL says this is
> non-spec and just converts the int to a string.

It is doubtful this is used by anything as the dartium version was broken
completely. 
Not that the dart2js version is unchanged except for the class not being tagged
as abstract.

I am open to the idea of just removing this class completely.

[Alan Knight, 2016-05-18 18:32:47]

On 2016/05/18 17:59:59, Jacob wrote:
>
https://codereview.chromium.org/1987073002/diff/1/sdk/lib/html/dart2js/html_d...
> File sdk/lib/html/dart2js/html_dart2js.dart (left):
> 
>
https://codereview.chromium.org/1987073002/diff/1/sdk/lib/html/dart2js/html_d...
> sdk/lib/html/dart2js/html_dart2js.dart:11648: -  String __getter__(int index);
> On 2016/05/18 17:17:04, Alan Knight wrote:
> > Are these used by anything?  If they are, this seems odd. IDL says this is
> > non-spec and just converts the int to a string.
> 
> It is doubtful this is used by anything as the dartium version was broken
> completely. 
> Not that the dart2js version is unchanged except for the class not being
tagged
> as abstract.
> 
> I am open to the idea of just removing this class completely.

It does look unused. It's supposedly the return type of the dataset attribute,
but at least in Dartium we seem to be getting a _DataAttributeMap wrapping an
_ElementAttributeMap.

[Jacob, 2016-05-18 19:49:13]

Description was changed from

==========
Strip unused functionality from dart:html and fix strong mode errors. Switch
from blacklisting pure interfaces to determining pure interfaces from the idl
and whitelisting impure interfaces we need for dart2js.

BUG=
==========

to

==========
Strip unused functionality from dart:html and fix strong mode errors. Switch
from blacklisting pure interfaces to determining pure interfaces from the idl
and whitelisting impure interfaces we need for dart2js.

BUG=
R=alanknight@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f26e522f84c5226beb0c57607571efe85a763e46
==========

[Jacob, 2016-05-18 19:49:15]

Committed patchset #1 (id:1) manually as
f26e522f84c5226beb0c57607571efe85a763e46 (presubmit successful).