Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1987053006: X87: [Interpreter] Remove InterpreterExitTrampoline and replace with returning to the entry trampol… (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Remove InterpreterExitTrampoline and replace with returning to the entry trampoline. port 39738bc90537a015bdaa4898478edaf88b021d11 (r36310) original commit message: In order to support compiling to baseline on return we need to be able to return to the actual return address. With this change this is what the Return bytecode now does, removing the need for the InterpreterExitTrampoline. This change also removes the InterpreterNotifyDeoptXXX builtins and unifies FCG and Igntion to both use NotifyDeoptXXX. As part of this change, FullCodegenerator::State is moved to Deoptimize::BailoutState. BUG= Committed: https://crrev.com/32ba3c91d1c27955a5444d9e8814357f8c3b462c Cr-Commit-Position: refs/heads/master@{#36344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -138 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 50 chunks +75 lines, -59 lines 0 comments Download
M src/x87/builtins-x87.cc View 6 chunks +29 lines, -79 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-19 03:15:00 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-05-19 03:38:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987053006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987053006/1
4 years, 7 months ago (2016-05-19 03:39:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 04:02:24 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 04:03:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32ba3c91d1c27955a5444d9e8814357f8c3b462c
Cr-Commit-Position: refs/heads/master@{#36344}

Powered by Google App Engine
This is Rietveld 408576698