Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1987053005: [Mac][Material Design] Fix toolbar icon hover bg for custom themes. (Closed)

Created:
4 years, 7 months ago by shrike
Modified:
4 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Fix toolbar icon hover bg for custom themes. The toolbar button was set to always show the light version of the hover background. For light themes, this rendered the hover background invisible. R=avi@chromium.org BUG=594678 Committed: https://crrev.com/94c1aa12416a70721b4bf4b0cb3b416282e5060e Cr-Commit-Position: refs/heads/master@{#394797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 7 months ago (2016-05-18 23:39:58 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 7 months ago (2016-05-19 03:38:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1987053005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1987053005/1
4 years, 7 months ago (2016-05-19 16:13:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 16:50:08 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 16:51:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94c1aa12416a70721b4bf4b0cb3b416282e5060e
Cr-Commit-Position: refs/heads/master@{#394797}

Powered by Google App Engine
This is Rietveld 408576698